Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8257166: [lworld] CCP fails to optimize FlatArrayCheckNode #282

Closed
wants to merge 1 commit into from

Conversation

@TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Nov 27, 2020

We hit assert(!t->is_flat() && !t->is_not_flat()) failed: Should have been optimized out during macro expansion of a FlatArrayCheckNode because the input array is known to be not flat but the check hasn't been optimized out by IGVN. The problem is that when CCP processes the node via FlatArrayCheckNode::Value the type immediately goes from TOP to BOTTOM because the input array hasn't been processed yet (still has type TOP). Afterwards, the node is not processed anymore although the type could be improved once the input array has been processed and is now known to be not flat.

We should add verification code that catches such cases. I've filed JDK-8257197 to do this in mainline. A quick prototype suggests that we have multiple similar issues in mainline code.

Thanks,
Tobias


Progress

  • Change must not contain extraneous whitespace

Testing

Linux x64 Windows x64 macOS x64
Build ✔️ (5/5 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) (1/9 failed) (8/9 running) (8/9 running)

Failed test task

Issue

  • JDK-8257166: [lworld] CCP fails to optimize FlatArrayCheckNode

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/282/head:pull/282
$ git checkout pull/282

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 27, 2020

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 27, 2020

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257166: [lworld] CCP fails to optimize FlatArrayCheckNode

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 27, 2020

Webrevs

@TobiHartmann
Copy link
Member Author

@TobiHartmann TobiHartmann commented Nov 27, 2020

/integrate

@openjdk openjdk bot closed this Nov 27, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 27, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 27, 2020

@TobiHartmann Pushed as commit 41ee0c8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant