New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8243623: [lworld] Syntax and other mechanical changes in langtools tests for JDK-8237072 #29
Conversation
…sts for JDK-8237072
|
@sadayapalam This change now passes all automated pre-integration checks, type
Since the source branch of this PR was last updated there have been 6 commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge
|
Webrevs
|
test/langtools/tools/javac/valhalla/lworld-values/ArrayCreationWithQuestion.java:27 Otherwise, good. |
/integrate |
@sadayapalam The following commits have been pushed to lworld since your change was applied:
Your commit was automatically rebased without conflicts. Pushed as commit 4c2f8be. |
Jim,
May I request you to review these changes to langtools tests that anticipate and
align with JDK-8237072 ? These changes are mechanical in nature and I decided it
is best to separate them from the RFR for JDK-8237072 itself to help create sharper
focus on the important pieces there. (Non-mechanical meaningful test changes with
be included in that RFR itself)
JDK-8237072 adds supports for the new syntax notation of V.ref and V.val to
refer to the reference projection of a value type V and its value projection.
The old syntax of V? is withdrawn. This change also has class file implications
where the descriptor/signature encodings will now start mentioning $ref in the
class pool entries. Also every inline type results in two class files now
one for each projection - with the reference projection class being the superclass
of the inline class.
I'll push them after your review and after JDK-8237072 itself is pushed.
Thanks in advance.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/valhalla pull/29/head:pull/29
$ git checkout pull/29