Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8243623: [lworld] Syntax and other mechanical changes in langtools tests for JDK-8237072 #29

Closed
wants to merge 2 commits into from

Conversation

sadayapalam
Copy link
Collaborator

@sadayapalam sadayapalam commented Apr 27, 2020

Jim,

May I request you to review these changes to langtools tests that anticipate and
align with JDK-8237072 ? These changes are mechanical in nature and I decided it
is best to separate them from the RFR for JDK-8237072 itself to help create sharper
focus on the important pieces there. (Non-mechanical meaningful test changes with
be included in that RFR itself)

JDK-8237072 adds supports for the new syntax notation of V.ref and V.val to
refer to the reference projection of a value type V and its value projection.
The old syntax of V? is withdrawn. This change also has class file implications
where the descriptor/signature encodings will now start mentioning $ref in the
class pool entries. Also every inline type results in two class files now
one for each projection - with the reference projection class being the superclass
of the inline class.

I'll push them after your review and after JDK-8237072 itself is pushed.
Thanks in advance.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8243623: [lworld] Syntax and other mechanical changes in langtools tests for JDK-8237072

Reviewers

  • JimLaskey (no known github.com user name / role)

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/29/head:pull/29
$ git checkout pull/29

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 27, 2020

👋 Welcome back sadayapalam! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request.

@openjdk
Copy link

openjdk bot commented Apr 27, 2020

@sadayapalam This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8243623: [lworld] Syntax and other mechanical changes in langtools tests for JDK-8237072
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 6 commits pushed to the lworld branch:

  • 4c2f8be: 8243623: [lworld] Syntax and other mechanical changes in langtools tests for JDK-8237072
  • 40289cf: 8243626: [lworld] Co-evolve hotspot-runtime tests along with JDK-8237072
  • 9ef4318: 8243627: [lworld] Co-evolve jdk-valhalla tests along with JDK-8237072
  • a3a846d: 8237072: [lworld] Add support for denoting and deriving the reference projection
  • 6742fab: 8244339: [lworld] JIT support for inline types with abstract class supertypes
  • 7502797: 8244092: [lworld] TestC2CCalls segfaults in frame::sender_for_compiled_frame with ZGC

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge lworld into your branch, and then specify the current head hash when integrating, like this: /integrate 4c2f8bee278599e37b643978a75bc281aa9ef4e4.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

mlbridge bot commented Apr 27, 2020

Webrevs

@JimLaskey
Copy link
Member

JimLaskey commented Apr 27, 2020

test/langtools/tools/javac/valhalla/lworld-values/ArrayCreationWithQuestion.java:27
Indentation (tab vs space)
test/langtools/tools/javac/valhalla/lworld-values/CheckQuestionInMessages.java:13
X.ref[] xa = new Object[10]; should it be X.ref[] xa = new Object.ref[10]; I'm sure it is correct (Object.ref doesn't exist) but there is an inconsistency with old code. Maybe add a comment.

Otherwise, good.

@sadayapalam
Copy link
Collaborator Author

sadayapalam commented May 5, 2020

/integrate

@openjdk openjdk bot closed this May 5, 2020
@openjdk openjdk bot added integrated and removed ready labels May 5, 2020
@openjdk
Copy link

openjdk bot commented May 5, 2020

@sadayapalam The following commits have been pushed to lworld since your change was applied:

  • 40289cf: 8243626: [lworld] Co-evolve hotspot-runtime tests along with JDK-8237072
  • 9ef4318: 8243627: [lworld] Co-evolve jdk-valhalla tests along with JDK-8237072
  • a3a846d: 8237072: [lworld] Add support for denoting and deriving the reference projection
  • 6742fab: 8244339: [lworld] JIT support for inline types with abstract class supertypes
  • 7502797: 8244092: [lworld] TestC2CCalls segfaults in frame::sender_for_compiled_frame with ZGC

Your commit was automatically rebased without conflicts.

Pushed as commit 4c2f8be.

@openjdk openjdk bot removed the rfr label May 5, 2020
@sadayapalam sadayapalam deleted the JDK-8243623 branch May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants