Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8257657: [lworld] TestLWorld and TestNullableInlineTypes fail during IR verification #291

Closed
wants to merge 1 commit into from

Conversation

TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Dec 3, 2020

#289 removed some deprecated flags from the test scenarios and accidentally changed the extra flags for the default scenarios leading to failures in IR verification (due to different flag settings).

Thanks,
Tobias


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8257657: [lworld] TestLWorld and TestNullableInlineTypes fail during IR verification

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/291/head:pull/291
$ git checkout pull/291

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 3, 2020

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 3, 2020

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257657: [lworld] TestLWorld and TestNullableInlineTypes fail during IR verification

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 118 new commits pushed to the lworld branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@TobiHartmann
Copy link
Member Author

TobiHartmann commented Dec 3, 2020

/integrate

@openjdk openjdk bot closed this Dec 3, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 3, 2020
@openjdk
Copy link

openjdk bot commented Dec 3, 2020

@TobiHartmann Since your change was applied there have been 118 commits pushed to the lworld branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 8408e30.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Dec 3, 2020

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant