Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8257776: [valhalla:jep390] Add disclaimer about future changes to value-based classes #294

Closed
wants to merge 4 commits into from

Conversation

dansmithcode
Copy link
Collaborator

@dansmithcode dansmithcode commented Dec 4, 2020

Addressing CSR feedback by mentioning the possibility of future behavioral changes to value-based classes.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8257776: [valhalla:jep390] Add disclaimer about future changes to value-based classes

Reviewers

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/294/head:pull/294
$ git checkout pull/294

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 4, 2020

👋 Welcome back dlsmith! A progress list of the required criteria for merging this PR into jep390 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Dec 4, 2020
@mlbridge
Copy link

mlbridge bot commented Dec 4, 2020

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 4, 2020

@dansmithcode This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257776: [valhalla:jep390] Add disclaimer about future changes to value-based classes

Reviewed-by: mchung, rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jep390 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jep390 branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 4, 2020
@dansmithcode
Copy link
Collaborator Author

dansmithcode commented Dec 4, 2020

/integrate

@openjdk openjdk bot closed this Dec 4, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 4, 2020
@openjdk
Copy link

openjdk bot commented Dec 4, 2020

@dansmithcode Pushed as commit 54ba37b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants