Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8243625: [lworld] Co-evolve hotspot-compiler tests along with JDK-8237072 #30

Closed
wants to merge 3 commits into from

Conversation

@sadayapalam
Copy link
Collaborator

@sadayapalam sadayapalam commented Apr 27, 2020

Tobias,

May I request you to review these changes to hotspot-compiler tests that anticipate
and align with JDK-8237072 ? These changes are mechanical in nature and I decided it
is best to separate them from the RFR for JDK-8237072 itself to help create sharper
focus on the important pieces there.

JDK-8237072 adds supports for the new syntax notation of V.ref and V.val to
refer to the reference projection of a value type V and its value projection.
The old syntax of V? is withdrawn. This change also has class file implications
where the descriptor/signature encodings will now start mentioning $ref in the
class pool entries. Also every inline type results in two class files now
one for each projection - with the reference projection class being the superclass
of the inline class.

I'll push them after your review and after JDK-8237072 itself is pushed.
Thanks in advance.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8243625: [lworld] Co-evolve hotspot-compiler tests along with JDK-8237072

Reviewers

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/30/head:pull/30
$ git checkout pull/30

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 27, 2020

👋 Welcome back sadayapalam! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 27, 2020

@sadayapalam This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8243625: [lworld] Co-evolve hotspot-compiler tests along with JDK-8237072

Reviewed-by: thartmann
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

There are currently no new commits on the lworld branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 4c2f8bee278599e37b643978a75bc281aa9ef4e4.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 27, 2020

Webrevs

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Thanks for fixing. Looks good to me!

@TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Apr 30, 2020

Here are some more adjustments needed:
compilerTestFixes.txt

All the remaining failures are JIT bugs. I'll work on them next.

@sadayapalam
Copy link
Collaborator Author

@sadayapalam sadayapalam commented May 5, 2020

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented May 5, 2020

@sadayapalam this pull request can not be integrated into lworld due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout JDK-8243625
git fetch https://git.openjdk.java.net/valhalla lworld
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge lworld"
git push

@openjdk
Copy link

@openjdk openjdk bot commented May 5, 2020

@sadayapalam Your merge request cannot be fulfilled at this time, as the status check jcheck did not complete successfully

@sadayapalam
Copy link
Collaborator Author

@sadayapalam sadayapalam commented May 5, 2020

/integrate

@openjdk openjdk bot closed this May 5, 2020
@openjdk openjdk bot added integrated and removed ready labels May 5, 2020
@openjdk
Copy link

@openjdk openjdk bot commented May 5, 2020

@sadayapalam
Pushed as commit 08bfa8f.

@openjdk openjdk bot removed the rfr label May 5, 2020
@sadayapalam sadayapalam deleted the JDK-8243625 branch May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants