Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252024: [lworld] Lock ordering issue when printing nmethod labels #302

Closed
wants to merge 1 commit into from

Conversation

@TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Dec 14, 2020

We hit an assert while printing nmethod entry point labels when attempting to create a symbol from the SigEntry to iterate over. The problem is that we are holding the tty lock and symbol creation also acquires certain locks. I've refactored the code to completely avoid symbol creation and also fixed an issue where names of reference argument types are not printed anymore (because we don't keep track of that in SigEntry). I've also removed lots of dead code leftovers from old reserved entry support in the calling convention.

Thanks,
Tobias


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8252024: [lworld] Lock ordering issue when printing nmethod labels

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/302/head:pull/302
$ git checkout pull/302

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 14, 2020

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 14, 2020

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8252024: [lworld] Lock ordering issue when printing nmethod labels

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 14, 2020

Webrevs

@TobiHartmann
Copy link
Member Author

@TobiHartmann TobiHartmann commented Dec 14, 2020

/integrate

@openjdk openjdk bot closed this Dec 14, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 14, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Dec 14, 2020

@TobiHartmann Pushed as commit 34232ad.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant