Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8259804: Field.setAccessible should not allow changing fields of inline classes #307

Closed

Conversation

RogerRiggs
Copy link
Collaborator

@RogerRiggs RogerRiggs commented Jan 14, 2021

Update the javadoc for setAccessibleObject and Field.set to restrict setting of final fields.

Correct the javadoc to match the implementation changes made in 8237444: Trust final fields in records

Also, the corresponding test is updated to match the restrictions.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8259804: Field.setAccessible should not allow changing fields of inline classes

Reviewers

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/307/head:pull/307
$ git checkout pull/307

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 14, 2021

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Jan 14, 2021

@RogerRiggs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259804: Field.setAccessible should not allow changing fields of inline classes

Reviewed-by: mchung, chegar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 14, 2021

Webrevs

Copy link
Member

@mlchung mlchung left a comment

Thanks for updating the javadoc and test. The test can simply be reverted to the jdk/master version and no copyright header update needed.

@RogerRiggs
Copy link
Collaborator Author

@RogerRiggs RogerRiggs commented Jan 15, 2021

/integrate

@openjdk openjdk bot closed this Jan 15, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 15, 2021

@RogerRiggs Pushed as commit f5fb93c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RogerRiggs RogerRiggs deleted the 8259804-inline-accessible branch Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants