Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8244092: [lworld] TestC2CCalls segfaults in frame::sender_for_compiled_frame with ZGC #31

Closed
wants to merge 1 commit into from

Conversation

@TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Apr 29, 2020

Stack slot containing real_frame_size is trashed by ZCG barrier code in scalarized entry of C1 compiled code. As a result, we crash during stack walking. We should re-set it before jumping to the verified entry. Also refactored the related code and added an assert to catch this.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8244092: [lworld] TestC2CCalls segfaults in frame::sender_for_compiled_frame with ZGC

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/31/head:pull/31
$ git checkout pull/31

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 29, 2020

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 29, 2020

@TobiHartmann This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8244092: [lworld] TestC2CCalls segfaults in frame::sender_for_compiled_frame with ZGC
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

There are currently no new commits on the lworld branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate 21a4dae797e19c56f8b3effe604e4990df54edb7.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 29, 2020

Webrevs

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 30, 2020

Mailing list message from Roland Westrelin on valhalla-dev:

Stack slot containing real_frame_size is trashed by ZCG barrier code in scalarized entry of C1 compiled code. As a
result, we crash during stack walking. We should re-set it before jumping to the verified entry. Also refactored the
related code and added an assert to catch this.

Ok.

Roland.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 30, 2020

Mailing list message from Tobias Hartmann on valhalla-dev:

Thanks Roland!

Best regards,
Tobias

On 30.04.20 09:57, Roland Westrelin wrote:

Stack slot containing real_frame_size is trashed by ZCG barrier code in scalarized entry of C1 compiled code. As a
result, we crash during stack walking. We should re-set it before jumping to the verified entry. Also refactored the
related code and added an assert to catch this.

Ok.

Roland.

@TobiHartmann
Copy link
Member Author

@TobiHartmann TobiHartmann commented Apr 30, 2020

/integrate

@openjdk openjdk bot closed this Apr 30, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 30, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Apr 30, 2020

@TobiHartmann
Pushed as commit 7502797.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant