Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused field from Method #312

Closed
wants to merge 1 commit into from

Conversation

fparain
Copy link
Collaborator

@fparain fparain commented Jan 25, 2021

Remove an unused field from the Method class, leftover of the value types thread local buffer.


Progress

  • Change must not contain extraneous whitespace

Reviewers

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/312/head:pull/312
$ git checkout pull/312

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 25, 2021

👋 Welcome back fparain! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Jan 25, 2021

@fparain This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Remove unused field from Method

Reviewed-by: hseigel, lfoltan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 25, 2021

Webrevs

Copy link
Member

@hseigel hseigel left a comment

Hi Fred,
Changes look good and trivial.
Thanks, Harold

Copy link
Member

@lfoltan lfoltan left a comment

Looks good.
Lois

@fparain
Copy link
Collaborator Author

@fparain fparain commented Jan 26, 2021

Lois, Harold,

Thank you for the reviews.

Fred

@fparain
Copy link
Collaborator Author

@fparain fparain commented Jan 26, 2021

/integrate

@openjdk openjdk bot closed this Jan 26, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 26, 2021

@fparain Pushed as commit 2f35fb7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@fparain fparain deleted the method_small_cleanup branch Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants