Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lworld] Field::get should return default value instead of null on non-flattened inline field #314

Closed
wants to merge 4 commits into from

Conversation

mlchung
Copy link
Member

@mlchung mlchung commented Jan 26, 2021

A field could be of a non-flattened inline type. Unsafe::getReference(Object o, long offset, Class<?> valueType) should be used instead. The value type parameter is used to differentiate if the field is an inline type or not; if so, it will return an uninitialized value of the inline type.


Progress

  • Change must not contain extraneous whitespace

Reviewers

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/314/head:pull/314
$ git checkout pull/314

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 26, 2021

👋 Welcome back mchung! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Jan 26, 2021

@mlchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

[lworld] Field::get should return default value instead of null on non-flattened inline field

Reviewed-by: rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 26, 2021

Webrevs

@mlchung
Copy link
Member Author

@mlchung mlchung commented Jan 26, 2021

/integrate

@openjdk openjdk bot closed this Jan 26, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 26, 2021

@mlchung Pushed as commit a2e8c6b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants