Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261019: [lworld] valhalla/valuetypes/QTypeDescriptorTest.java "Illegal class name "QLine;" in class file $Proxy5" #320

Closed
wants to merge 2 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
@@ -1,5 +1,5 @@
/*
* Copyright (c) 1999, 2020, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 1999, 2021, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -453,7 +453,7 @@ protected ClassLoader getClassLoader() {
* class file generation process.
*/
private byte[] generateClassFile() {
visit(V16, accessFlags, dotToSlash(className), null,
visit(V17, accessFlags, dotToSlash(className), null,
Copy link
Member

@mlchung mlchung Feb 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, we can use the value of the system property java.class.version to prepare for future class file version change. But this requires parsing it to extract the major version.

I'm okay with this simple approach and remember to update it if the class file version is bumped.

Copy link
Member Author

@kelthuzadx kelthuzadx Feb 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems reasonable. When I fix another related fail, I can tweak this part.

JLR_PROXY, typeNames(interfaces));

/*