Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261021: [lworld] valhalla/valuetypes/LambdaConversion.java fails Illegal class name "QLambdaConversion$Pointer;" #321

Closed

Conversation

@kelthuzadx
Copy link
Member

@kelthuzadx kelthuzadx commented Feb 5, 2021

Hi all,

Can I have a review of this trivial fix?

The root cause of this problem is similar to PR #320. As explained before, in short, the major version of the dynamically generated bytecode does not match the version required by ClassFileParser::verify_legal_class_name, resulting in a ClassFormatError.

Thanks,
Yang Yi


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8261021: [lworld] valhalla/valuetypes/LambdaConversion.java fails Illegal class name "QLambdaConversion$Pointer;"

Reviewers

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/321/head:pull/321
$ git checkout pull/321

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 5, 2021

👋 Welcome back kelthuzadx! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Feb 5, 2021

@kelthuzadx This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261021: [lworld] valhalla/valuetypes/LambdaConversion.java fails Illegal class name "QLambdaConversion$Pointer;"

Reviewed-by: dsimms, rriggs, mchung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 236 new commits pushed to the lworld branch:

  • 4768ea2: 8261019: [lworld] valhalla/valuetypes/QTypeDescriptorTest.java "Illegal class name "QLine;" in class file $Proxy5"
  • c4f63d2: 8261264: [lworld] runtime/valhalla/inlinetypes tests fail to compile
  • 5f1e8d9: 8260606: Update Valhalla core-libs naming for methods related to primitive classes
  • ddfba61: 8261226: [lworld] Array access profiling should be disabled at compilation level 1 and 2
  • ce486c3: 8261037: [lworld] Assert during C2 compilation due to inconsistent JVMState at safepoint
  • 33dc4fb: Merge jdk
  • f025bc1: 8260301: misc gc/g1/unloading tests fails with "RuntimeException: Method could not be enqueued for compilation at level N"
  • 4a8b5c1: 8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m
  • 472bf62: 8258799: [Testbug] RandomCommandsTest must check if tested directive is added via jcmd
  • b0ee7a8: 8241995: Clarify InetSocketAddress::toString specification
  • ... and 226 more: https://git.openjdk.java.net/valhalla/compare/fbb8a6bdf878d2c370a0e78b04a5a5736f2eb765...lworld

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@MrSimms, @RogerRiggs, @mlchung) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 5, 2021

Webrevs

@MrSimms MrSimms self-requested a review Feb 5, 2021
MrSimms
MrSimms approved these changes Feb 5, 2021
Copy link
Member

@MrSimms MrSimms left a comment

Looks good, thanks for the find

mlchung
mlchung approved these changes Feb 5, 2021
@kelthuzadx
Copy link
Member Author

@kelthuzadx kelthuzadx commented Feb 5, 2021

/integrate

@openjdk openjdk bot added the sponsor label Feb 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 5, 2021

@kelthuzadx
Your change (at version c4f49d1) is now ready to be sponsored by a Committer.

@kelthuzadx
Copy link
Member Author

@kelthuzadx kelthuzadx commented Feb 5, 2021

Thank you all for your review! @MrSimms @RogerRiggs @mlchung

@MrSimms
Copy link
Member

@MrSimms MrSimms commented Feb 8, 2021

/sponsor

@openjdk openjdk bot closed this Feb 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 8, 2021

@MrSimms @kelthuzadx Since your change was applied there have been 236 commits pushed to the lworld branch:

  • 4768ea2: 8261019: [lworld] valhalla/valuetypes/QTypeDescriptorTest.java "Illegal class name "QLine;" in class file $Proxy5"
  • c4f63d2: 8261264: [lworld] runtime/valhalla/inlinetypes tests fail to compile
  • 5f1e8d9: 8260606: Update Valhalla core-libs naming for methods related to primitive classes
  • ddfba61: 8261226: [lworld] Array access profiling should be disabled at compilation level 1 and 2
  • ce486c3: 8261037: [lworld] Assert during C2 compilation due to inconsistent JVMState at safepoint
  • 33dc4fb: Merge jdk
  • f025bc1: 8260301: misc gc/g1/unloading tests fails with "RuntimeException: Method could not be enqueued for compilation at level N"
  • 4a8b5c1: 8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m
  • 472bf62: 8258799: [Testbug] RandomCommandsTest must check if tested directive is added via jcmd
  • b0ee7a8: 8241995: Clarify InetSocketAddress::toString specification
  • ... and 226 more: https://git.openjdk.java.net/valhalla/compare/fbb8a6bdf878d2c370a0e78b04a5a5736f2eb765...lworld

Your commit was automatically rebased without conflicts.

Pushed as commit b2c84c7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kelthuzadx kelthuzadx deleted the valhalla_illegal_name_2 branch Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants