Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261264: [lworld] runtime/valhalla/inlinetypes tests fail to compile #324

Closed
wants to merge 1 commit into from

Conversation

hseigel
Copy link
Member

@hseigel hseigel commented Feb 5, 2021

Please review this small fix to have runtime/valhalla tests call method Class.isPrimitiveClass() instead of Class.isInlineClass().

Thanks, Harold


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8261264: [lworld] runtime/valhalla/inlinetypes tests fail to compile

Reviewers

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/324/head:pull/324
$ git checkout pull/324

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 5, 2021

👋 Welcome back hseigel! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Feb 5, 2021

@hseigel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261264: [lworld] runtime/valhalla/inlinetypes tests fail to compile

Reviewed-by: rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 5, 2021

Webrevs

Copy link
Collaborator

@RogerRiggs RogerRiggs left a comment

Sorry Harold I missed these.

@hseigel
Copy link
Member Author

@hseigel hseigel commented Feb 5, 2021

Thanks Roger for the reivew!

/integrate

@openjdk openjdk bot closed this Feb 5, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 5, 2021

@hseigel Pushed as commit c4f63d2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants