Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8241894: [lworld] crash in ZGC running InlineOops.java#id3 #327

Closed
wants to merge 1 commit into from

Conversation

MrSimms
Copy link
Member

@MrSimms MrSimms commented Feb 9, 2021

Remove raw oop load from CollectOops::do_oop()


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8241894: [lworld] crash in ZGC running InlineOops.java#id3

Reviewers

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/327/head:pull/327
$ git checkout pull/327

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 9, 2021

👋 Welcome back dsimms! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 9, 2021

@MrSimms This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8241894: [lworld] crash in ZGC running InlineOops.java#id3

Reviewed-by: fparain

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the lworld branch:

  • 3d47537: 8261439: [lworld] update use of "inline class" to "primitive class" in java/lang/invoke and com/sun/jdi/ tests
  • 693282f: 8261393: [lworld] Adopt primitive' as the modifier in declaration of identity free classes in lieu of inline`

Please see this link for an up-to-date comparison between the source branch of this pull request and the lworld branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

mlbridge bot commented Feb 9, 2021

Webrevs

fparain
fparain approved these changes Feb 9, 2021
Copy link
Collaborator

@fparain fparain left a comment

Looks good to me.
Thank you for fixing this long standing issue.

Fred

@MrSimms
Copy link
Member Author

MrSimms commented Feb 9, 2021

/integrate

@openjdk openjdk bot closed this Feb 9, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 9, 2021
@openjdk
Copy link

openjdk bot commented Feb 9, 2021

@MrSimms Since your change was applied there have been 2 commits pushed to the lworld branch:

  • 3d47537: 8261439: [lworld] update use of "inline class" to "primitive class" in java/lang/invoke and com/sun/jdi/ tests
  • 693282f: 8261393: [lworld] Adopt primitive' as the modifier in declaration of identity free classes in lieu of inline`

Your commit was automatically rebased without conflicts.

Pushed as commit 84c3e32.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@MrSimms MrSimms deleted the 8241894 branch Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants