Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8244339: [lworld] JIT support for inline types with abstract class supertypes #33

Closed
wants to merge 2 commits into from

Conversation

TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented May 4, 2020

C1 and C2 do not correctly handle and optimize inline types with abstract class supertypes and corresponding array covariance. I've fixed and refactored related code. Added lots of tests and IR verification of optimizations.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8244339: [lworld] JIT support for inline types with abstract class supertypes

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/33/head:pull/33
$ git checkout pull/33

@bridgekeeper
Copy link

bridgekeeper bot commented May 4, 2020

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request.

@openjdk
Copy link

openjdk bot commented May 4, 2020

@TobiHartmann This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8244339: [lworld] JIT support for inline types with abstract class supertypes
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the lworld branch:

  • 6742fab: 8244339: [lworld] JIT support for inline types with abstract class supertypes

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge lworld into your branch, and then specify the current head hash when integrating, like this: /integrate 6742fab881b455f27b39231f465d5ba73b9cd1f6.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

mlbridge bot commented May 4, 2020

Webrevs

@mlbridge
Copy link

mlbridge bot commented May 4, 2020

Mailing list message from Roland Westrelin on valhalla-dev:

C1 and C2 do not correctly handle and optimize inline types with abstract class supertypes and corresponding array
covariance. I've fixed and refactored related code. Added lots of tests and IR verification of optimizations.

Looks ok to me.

Roland.

@TobiHartmann
Copy link
Member Author

TobiHartmann commented May 4, 2020

Thanks Roland!

@TobiHartmann
Copy link
Member Author

TobiHartmann commented May 4, 2020

/integrate

@openjdk openjdk bot closed this May 4, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels May 4, 2020
@openjdk
Copy link

openjdk bot commented May 4, 2020

@TobiHartmann
Pushed as commit 6742fab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant