8261956: [type-restrictions] Support RestrictedMethod in the interpreter

[fparain]

Please review these changes adding support for RestrictedMethod in the interpreter.
Types restrictions are enforced in the following bytecodes:

• invokevirtual
• invokestatic
• invokespecial
• invokeinterface

The changeset also includes a small fix to prevent previous type restrictions related tests to fail.

Thank you,

Fred

---

Progress

• Change must not contain extraneous whitespace

Issue

• JDK-8261956: [type-restrictions] Support RestrictedMethod in the interpreter

Reviewers

• David Simms (@MrSimms - Committer) ⚠️ Review applies to 6b0face
• Harold Seigel (@hseigel - Committer)

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/341/head:pull/341
$ git checkout pull/341

[bridgekeeper]

👋 Welcome back fparain! A progress list of the required criteria for merging this PR into type-restrictions will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@fparain This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261956: [type-restrictions] Support RestrictedMethod in the interpreter

Reviewed-by: dsimms, hseigel

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 191 new commits pushed to the type-restrictions branch:

• 803ebc4: Merge lworld
• e31335f: Merge jdk
• e7e20d4: 8261711: Clhsdb "versioncheck true" throws NPE every time
• 55d7bbc: 8261607: SA attach is exceeding JNI Local Refs capacity
• 0a50688: 8241372: Several test failures due to javax.net.ssl.SSLException: Connection reset
• 61a659f: 8260415: Remove unused class ReferenceProcessorMTProcMutator
• 6b6f794: 8248223: KeyAgreement spec update on multi-party key exchange support
• 8ba390d: 8261753: Test java/lang/System/OsVersionTest.java still failing on BigSur patch versions after JDK-8253702
• 16bd7d3: 8261336: IGV: enhance default filters
• 3f8819c: 8261501: Shenandoah: reconsider heap statistics memory ordering
• ... and 181 more: https://git.openjdk.java.net/valhalla/compare/5f6ef0f4ab619227beb49bf264ef1eab9a0cb0e3...type-restrictions

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the type-restrictions branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 01: Full - Incremental (912eee2)
• 00: Full (6b0face)

[MrSimms]

Looks good

[hseigel]

Hi Fred,
Maybe move the classFileParser.cpp code, that checks for the restricted_method attribute, inside of an "if (_major_version >= JAVA_17_VERSION)" conditional?

Thanks, Harold

[fparain]

Harold,

Following your suggestion, a class file version check has been added for the RestrictedMethod attribute.

Fred

[hseigel]

The classFileParser.cpp change looks good. Thanks for changing it.

Harold

[fparain]

/integrate

[openjdk]

@fparain Since your change was applied there have been 191 commits pushed to the type-restrictions branch:

• 803ebc4: Merge lworld
• e31335f: Merge jdk
• e7e20d4: 8261711: Clhsdb "versioncheck true" throws NPE every time
• 55d7bbc: 8261607: SA attach is exceeding JNI Local Refs capacity
• 0a50688: 8241372: Several test failures due to javax.net.ssl.SSLException: Connection reset
• 61a659f: 8260415: Remove unused class ReferenceProcessorMTProcMutator
• 6b6f794: 8248223: KeyAgreement spec update on multi-party key exchange support
• 8ba390d: 8261753: Test java/lang/System/OsVersionTest.java still failing on BigSur patch versions after JDK-8253702
• 16bd7d3: 8261336: IGV: enhance default filters
• 3f8819c: 8261501: Shenandoah: reconsider heap statistics memory ordering
• ... and 181 more: https://git.openjdk.java.net/valhalla/compare/5f6ef0f4ab619227beb49bf264ef1eab9a0cb0e3...type-restrictions

Your commit was automatically rebased without conflicts.

Pushed as commit 9c991d9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.