Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261956: [type-restrictions] Support RestrictedMethod in the interpreter #341

Closed
wants to merge 5 commits into from

Conversation

@fparain
Copy link
Collaborator

@fparain fparain commented Feb 18, 2021

Please review these changes adding support for RestrictedMethod in the interpreter.
Types restrictions are enforced in the following bytecodes:

  • invokevirtual
  • invokestatic
  • invokespecial
  • invokeinterface

The changeset also includes a small fix to prevent previous type restrictions related tests to fail.

Thank you,

Fred


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8261956: [type-restrictions] Support RestrictedMethod in the interpreter

Reviewers

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/341/head:pull/341
$ git checkout pull/341

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 18, 2021

👋 Welcome back fparain! A progress list of the required criteria for merging this PR into type-restrictions will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Feb 18, 2021

@fparain This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8261956: [type-restrictions] Support RestrictedMethod in the interpreter

Reviewed-by: dsimms, hseigel

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 191 new commits pushed to the type-restrictions branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the type-restrictions branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 18, 2021

Webrevs

Copy link
Member

@MrSimms MrSimms left a comment

Looks good

Copy link
Member

@hseigel hseigel left a comment

Hi Fred,
Maybe move the classFileParser.cpp code, that checks for the restricted_method attribute, inside of an "if (_major_version >= JAVA_17_VERSION)" conditional?

Thanks, Harold

@fparain
Copy link
Collaborator Author

@fparain fparain commented Feb 18, 2021

Harold,

Following your suggestion, a class file version check has been added for the RestrictedMethod attribute.

Fred

Copy link
Member

@hseigel hseigel left a comment

The classFileParser.cpp change looks good. Thanks for changing it.

Harold

@fparain
Copy link
Collaborator Author

@fparain fparain commented Feb 22, 2021

/integrate

@openjdk openjdk bot closed this Feb 22, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 22, 2021

@fparain Since your change was applied there have been 191 commits pushed to the type-restrictions branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 9c991d9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@fparain fparain deleted the tr_methods branch Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants