New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8261956: [type-restrictions] Support RestrictedMethod in the interpreter #341
Conversation
|
@fparain This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 191 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
Webrevs
|
Hi Fred,
Maybe move the classFileParser.cpp code, that checks for the restricted_method attribute, inside of an "if (_major_version >= JAVA_17_VERSION)" conditional?
Thanks, Harold
Harold, Following your suggestion, a class file version check has been added for the RestrictedMethod attribute. Fred |
The classFileParser.cpp change looks good. Thanks for changing it.
Harold
/integrate |
@fparain Since your change was applied there have been 191 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 9c991d9. |
Please review these changes adding support for RestrictedMethod in the interpreter.
Types restrictions are enforced in the following bytecodes:
The changeset also includes a small fix to prevent previous type restrictions related tests to fail.
Thank you,
Fred
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/valhalla pull/341/head:pull/341
$ git checkout pull/341