Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261874: [lworld] Non-flattened array blocks scalarization of inline type #342

wants to merge 1 commit into from


Copy link

@TobiHartmann TobiHartmann commented Feb 18, 2021

We hit an assert because an inline type is not scalarized in the debug info of a safepoint. The problem is that the inline type is stored in a non-flattened array which blocks scalarization. Once the non-flattened array is scalarized itself, the inline type could be scalarized as well but we don't keep track of its field values long enough (we remove the InlineTypePtrNode before macro expansion). The solution is to keep InlineTypePtrNodes until after macro expansion. I've also converted scalarization in safepoints into an ideal transformation, refactored related code and added the corresponding IR verification tests.

Best regards,


  • Change must not contain extraneous whitespace


  • JDK-8261874: [lworld] Non-flattened array blocks scalarization of inline type


$ git fetch pull/342/head:pull/342
$ git checkout pull/342

Copy link

bridgekeeper bot commented Feb 18, 2021

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Copy link

openjdk bot commented Feb 18, 2021

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file for details.

After integration, the commit message for the final commit will be:

8261874: [lworld] Non-flattened array blocks scalarization of inline type

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

Copy link

mlbridge bot commented Feb 18, 2021


Copy link
Member Author

TobiHartmann commented Feb 19, 2021


@openjdk openjdk bot closed this Feb 19, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 19, 2021
Copy link

openjdk bot commented Feb 19, 2021

@TobiHartmann Pushed as commit e88ff83.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant