Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8262025: [lworld] C2 should optimize acmp of the same inline type #343

Closed
wants to merge 2 commits into from

Conversation

@TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Feb 19, 2021

I've noticed that a simple val == val where val is an inline type is not optimized by C2. The reason is that we are buffering the inline type operands before applying optimizations. The fix is to simply check for equality before that.

Best regards,
Tobias


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8262025: [lworld] C2 should optimize acmp of the same inline type

Reviewers

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/343/head:pull/343
$ git checkout pull/343

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 19, 2021

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Feb 19, 2021

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8262025: [lworld] C2 should optimize acmp of the same inline type

Reviewed-by: dsimms

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the lworld branch:

  • f421b93: 8261782: [lworld] Add support for PrimitiveObject interface

Please see this link for an up-to-date comparison between the source branch of this pull request and the lworld branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 19, 2021

Webrevs

@TobiHartmann
Copy link
Member Author

@TobiHartmann TobiHartmann commented Feb 19, 2021

I've noticed that with the fix, the Ifacmp.java test started to time out due to an endless loop in the testAlot method. It seems that this is due to C2 now being able to fully remove the loop (because it can prove that a == b) and therefore also the safepoint that would trigger a GC. I've added a call to System.gc. @MrSimms does that seem reasonable to you?

Copy link
Member

@MrSimms MrSimms left a comment

Runtime bits look good.

@TobiHartmann
Copy link
Member Author

@TobiHartmann TobiHartmann commented Feb 22, 2021

Thanks for the review!

@TobiHartmann
Copy link
Member Author

@TobiHartmann TobiHartmann commented Feb 22, 2021

/integrate

@openjdk openjdk bot closed this Feb 22, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 22, 2021

@TobiHartmann Since your change was applied there has been 1 commit pushed to the lworld branch:

  • f421b93: 8261782: [lworld] Add support for PrimitiveObject interface

Your commit was automatically rebased without conflicts.

Pushed as commit 11cda28.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants