Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8262308: [lworld] Various small C2 fixes for bugs found by stress testing #351

Closed
wants to merge 2 commits into from

Conversation

TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Feb 25, 2021

More testing with stress flags enabled revealed the following bugs:

  • We should not call remove_dead_node from InlineTypeBaseNode::Ideal. Instead, we should just make sure the dead node is on the IGVN worklist to be removed. I've also removed the VerifyVM option from the framework. Such flags can be added manually or via the CI job definitions.
  • PhaseMacroExpand::process_users_of_allocation needs to handle InlineTypePtrNodes because we now keep them until after macro expansion.
  • GraphKit::type_check_receiver should create a InlineTypePtrNode instead of a InlineTypeNode because it operates on pointers.

I have a job definition file with all these stress flags enabled that I will integrate separately soon.

Best regards,
Tobias


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8262308: [lworld] Various small C2 fixes for bugs found by stress testing

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/351/head:pull/351
$ git checkout pull/351

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 25, 2021

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 25, 2021

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8262308: [lworld] Various small C2 fixes for bugs found by stress testing

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 110 new commits pushed to the lworld branch:

  • ab51b60: Merge jdk
  • a50725d: 8254001: [Metrics] Enhance parsing of cgroup interface files for version detection
  • 6549212: 8262315: missing ';' in generated entities
  • d70fd7b: 8258855: Two tests sun/security/krb5/auto/ReplayCacheTestProc.java and ReplayCacheTestProcWithMD5.java failed on OL8.3
  • 9d9ad96: 8261919: java/util/Locale/LocaleProvidersRun.java failed with "RuntimeException: Expected log was not emitted. LogRecord: null"
  • 2c99bad: 8261920: [AIX] jshell command throws java.io.IOError on non English locales
  • 8c07063: 8262259: Remove unused variable in MethodLiveness::BasicBlock::compute_gen_kill_single
  • 0d2dbd2: 8262027: Improve how HttpConnection detects a closed channel when taking/returning a connection to the pool
  • 382e38d: 8256438: AArch64: Implement match rules with ROR shift register value
  • fac37bf: 8262269: javadoc test TestGeneratedClasses.java fails on Windows
  • ... and 100 more: https://git.openjdk.java.net/valhalla/compare/1816db371d9d333b337228d7436d91a3b3e150cd...lworld

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

mlbridge bot commented Feb 25, 2021

Webrevs

@TobiHartmann
Copy link
Member Author

TobiHartmann commented Feb 25, 2021

/integrate

@openjdk openjdk bot closed this Feb 25, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 25, 2021
@openjdk
Copy link

openjdk bot commented Feb 25, 2021

@TobiHartmann Since your change was applied there have been 110 commits pushed to the lworld branch:

  • ab51b60: Merge jdk
  • a50725d: 8254001: [Metrics] Enhance parsing of cgroup interface files for version detection
  • 6549212: 8262315: missing ';' in generated entities
  • d70fd7b: 8258855: Two tests sun/security/krb5/auto/ReplayCacheTestProc.java and ReplayCacheTestProcWithMD5.java failed on OL8.3
  • 9d9ad96: 8261919: java/util/Locale/LocaleProvidersRun.java failed with "RuntimeException: Expected log was not emitted. LogRecord: null"
  • 2c99bad: 8261920: [AIX] jshell command throws java.io.IOError on non English locales
  • 8c07063: 8262259: Remove unused variable in MethodLiveness::BasicBlock::compute_gen_kill_single
  • 0d2dbd2: 8262027: Improve how HttpConnection detects a closed channel when taking/returning a connection to the pool
  • 382e38d: 8256438: AArch64: Implement match rules with ROR shift register value
  • fac37bf: 8262269: javadoc test TestGeneratedClasses.java fails on Windows
  • ... and 100 more: https://git.openjdk.java.net/valhalla/compare/1816db371d9d333b337228d7436d91a3b3e150cd...lworld

Your commit was automatically rebased without conflicts.

Pushed as commit 0dfcc94.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant