Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265118: [lworld] C1 should optimize inline type checkcasts #383

Closed
wants to merge 1 commit into from

Conversation

TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Apr 13, 2021

C1's Canonicalizer::do_CheckCast should optimize casts to inline klasses when types are known.

I've added an additional test for null casts and fixed (unrelated) TestFieldTypeMismatch.java which was part of the wrong package.

Thanks,
Tobias


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8265118: [lworld] C1 should optimize inline type checkcasts

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/383/head:pull/383
$ git checkout pull/383

Update a local copy of the PR:
$ git checkout pull/383
$ git pull https://git.openjdk.java.net/valhalla pull/383/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 383

View PR using the GUI difftool:
$ git pr show -t 383

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/383.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 13, 2021

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 13, 2021

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265118: [lworld] C1 should optimize inline type checkcasts

Reviewed-by: fparain

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

mlbridge bot commented Apr 13, 2021

Webrevs

Copy link
Collaborator

@fparain fparain left a comment

Looks good to me.

Fred

@TobiHartmann
Copy link
Member Author

TobiHartmann commented Apr 14, 2021

Thanks for the review, Fred!

@TobiHartmann
Copy link
Member Author

TobiHartmann commented Apr 14, 2021

/integrate

@openjdk openjdk bot closed this Apr 14, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 14, 2021
@openjdk
Copy link

openjdk bot commented Apr 14, 2021

@TobiHartmann Pushed as commit e9c78ce.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants