Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8244559: [lworld] Lambda and parameterized ref of an inline type doesn't work well #39

Closed
wants to merge 1 commit into from

Conversation

sadayapalam
Copy link
Collaborator

@sadayapalam sadayapalam commented May 8, 2020

Jim, Could you please review this patch which fixes two problems? TIA.

(1) Basically, the code to create AST nodes from a Type is not handling reference
projection types properly. Given a type V.ref<T>, it ends up creating AST that
look like V<T>.ref rather than V.ref<T>

(2) When V<T> is a nested static class, the construct V.ref<T> appears to
access a static member type of the parameterized type V which is usually an
error. But ref is not really a member and so this should be tolerated.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8244559: [lworld] Lambda and parameterized ref of an inline type doesn't work well

Reviewers

  • JimLaskey (no known github.com user name / role)

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/39/head:pull/39
$ git checkout pull/39

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 8, 2020

👋 Welcome back sadayapalam! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request.

@openjdk
Copy link

@openjdk openjdk bot commented May 8, 2020

@sadayapalam This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8244559: [lworld] Lambda and parameterized ref of an inline type doesn't work well
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

There are currently no new commits on the lworld branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate b2f5a1a0da95f22762f81a64bcd992af993441b0.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented May 8, 2020

Webrevs

@sadayapalam
Copy link
Collaborator Author

@sadayapalam sadayapalam commented May 8, 2020

/integrate

@openjdk openjdk bot closed this May 8, 2020
@openjdk openjdk bot added integrated and removed ready labels May 8, 2020
@openjdk
Copy link

@openjdk openjdk bot commented May 8, 2020

@sadayapalam
Pushed as commit e586cdb.

@openjdk openjdk bot removed the rfr label May 8, 2020
@sadayapalam sadayapalam deleted the JDK-8244559 branch May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants