Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh universal-type-var branch #392

Conversation

vicente-romero-oracle
Copy link
Contributor

@vicente-romero-oracle vicente-romero-oracle commented Apr 23, 2021


Progress

  • Change must not contain extraneous whitespace

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/392/head:pull/392
$ git checkout pull/392

Update a local copy of the PR:
$ git checkout pull/392
$ git pull https://git.openjdk.java.net/valhalla pull/392/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 392

View PR using the GUI difftool:
$ git pr show -t 392

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/392.diff

Nils Eliasson and others added 30 commits Apr 6, 2021
…intAssembly is requested

Reviewed-by: kvn, thartmann
Reviewed-by: kbarrett, ayang
Co-authored-by: Daniel Fuchs <dfuchs@openjdk.org>
Reviewed-by: bchristi, dfuchs
…y.SecureRandom nextFloat consecutive"

Reviewed-by: darcy, bpb, dcubed
…ils due to swapping not working

Reviewed-by: sgehwolf
…s_enctypes is not present

Reviewed-by: mullan
Co-authored-by: Wu Yan <wuyan34@huawei.com>
Co-authored-by: Ai Jiaming <aijiaming1@huawei.com>
Reviewed-by: kvn, vlivanov, thartmann
Reviewed-by: ayang, tschatzl
…e) should clearly mention which method it delegates the call to

Reviewed-by: aivanov, serb
@vicente-romero-oracle
Copy link
Contributor Author

vicente-romero-oracle commented Apr 23, 2021

/integrate

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 23, 2021

👋 Welcome back vromero! A progress list of the required criteria for merging this PR into universal-tvars will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Copy link
Collaborator

@mcimadamore mcimadamore left a comment

Looks good (well, looks as bad as any merge :-) )

@openjdk
Copy link

openjdk bot commented Apr 23, 2021

⚠️ @vicente-romero-oracle a branch with the same name as the source branch for this pull request (universal-tvars) is present in the target repository. If you eventually integrate this pull request then the branch universal-tvars in your personal fork will diverge once you sync your personal fork with the upstream repository.

To avoid this situation, create a new branch for your changes and reset the universal-tvars branch. You can do this by running the following commands in a local repository for your personal fork. Note: you do not have to name the new branch NEW-BRANCH-NAME.

$ git checkout -b NEW-BRANCH-NAME
$ git branch -f universal-tvars 94c281e2c2e4ec8aeb83f4ecd4c4189b1e6dc67f
$ git push -f origin universal-tvars

Then proceed to create a new pull request with NEW-BRANCH-NAME as the source branch and close this one.

@openjdk
Copy link

openjdk bot commented Apr 23, 2021

⚠️ @vicente-romero-oracle This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@openjdk
Copy link

openjdk bot commented Apr 23, 2021

@vicente-romero-oracle Your integration request cannot be fulfilled at this time, as the status check jcheck did not complete successfully

@openjdk
Copy link

openjdk bot commented Apr 23, 2021

@vicente-romero-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Merge valhalla:lworld

Reviewed-by: mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the universal-tvars branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the universal-tvars branch, type /integrate in a new comment.

@vicente-romero-oracle vicente-romero-oracle changed the title merging universal tvars with lworld Merge: universal-tvars with lworld Apr 23, 2021
@vicente-romero-oracle vicente-romero-oracle changed the title Merge: universal-tvars with lworld Merge valhalla:lworld Apr 23, 2021
@vicente-romero-oracle
Copy link
Contributor Author

vicente-romero-oracle commented Apr 23, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Apr 23, 2021

@vicente-romero-oracle This PR has not yet been marked as ready for integration.

@vicente-romero-oracle vicente-romero-oracle changed the title Merge valhalla:lworld Refresh universal-type-var branch Apr 23, 2021
@vicente-romero-oracle
Copy link
Contributor Author

vicente-romero-oracle commented Apr 23, 2021

/integrate

@openjdk openjdk bot closed this Apr 23, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 23, 2021
@openjdk
Copy link

openjdk bot commented Apr 23, 2021

@vicente-romero-oracle Pushed as commit 80ed064.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Apr 23, 2021

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment