Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266324: [lworld] [lw3] Component type of arrays of primitive objects incorrectly loaded at link time #396

Closed
wants to merge 1 commit into from

Conversation

fparain
Copy link
Collaborator

@fparain fparain commented Apr 29, 2021

Small fix to prevent the VM from loading component types of arrays of primitive objects at link time.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8266324: [lworld] [lw3] Component type of arrays of primitive objects incorrectly loaded at link time

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/396/head:pull/396
$ git checkout pull/396

Update a local copy of the PR:
$ git checkout pull/396
$ git pull https://git.openjdk.java.net/valhalla pull/396/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 396

View PR using the GUI difftool:
$ git pr show -t 396

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/396.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 29, 2021

👋 Welcome back fparain! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 29, 2021
@mlbridge
Copy link

mlbridge bot commented Apr 29, 2021

Webrevs

@fparain fparain changed the title 8266324: [lworld] [lw3] Component type of arrays of primitive objects incorrectly loaded at link timeFix earger loading for arrays 8266324: [lworld] [lw3] Component type of arrays of primitive objects incorrectly loaded at link time Apr 29, 2021
@openjdk
Copy link

openjdk bot commented Apr 29, 2021

@fparain This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266324: [lworld] [lw3] Component type of arrays of primitive objects incorrectly loaded at link time

Reviewed-by: hseigel, lfoltan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the lworld branch:

  • 17b12ac: 8265423: [lworld] Provide experimental support for generating a single class file per primitive class

Please see this link for an up-to-date comparison between the source branch of this pull request and the lworld branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 29, 2021
hseigel
hseigel approved these changes May 3, 2021
Copy link
Member

@hseigel hseigel left a comment

Looks good!
Thanks, Harold

lfoltan
lfoltan approved these changes May 3, 2021
Copy link
Member

@lfoltan lfoltan left a comment

Looks good.
Lois

@fparain
Copy link
Collaborator Author

fparain commented May 3, 2021

Thank you Lois and Harold!

Fred

@fparain
Copy link
Collaborator Author

fparain commented May 3, 2021

/integrate

@openjdk openjdk bot closed this May 3, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 3, 2021
@openjdk
Copy link

openjdk bot commented May 3, 2021

@fparain Since your change was applied there has been 1 commit pushed to the lworld branch:

  • 17b12ac: 8265423: [lworld] Provide experimental support for generating a single class file per primitive class

Your commit was automatically rebased without conflicts.

Pushed as commit 93c4160.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@fparain fparain deleted the qarrays_eargerloading branch Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants