Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265719: [lworld] CDS tests fail after the merge with master #401

Closed
wants to merge 1 commit into from

Conversation

@MrSimms
Copy link
Member

@MrSimms MrSimms commented May 4, 2021

Adjust the class list to also specify IdentityObject


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8265719: [lworld] CDS tests fail after the merge with master

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/401/head:pull/401
$ git checkout pull/401

Update a local copy of the PR:
$ git checkout pull/401
$ git pull https://git.openjdk.java.net/valhalla pull/401/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 401

View PR using the GUI difftool:
$ git pr show -t 401

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/401.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 4, 2021

👋 Welcome back dsimms! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented May 4, 2021

@MrSimms This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265719: [lworld] CDS tests fail after the merge with master

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented May 4, 2021

Webrevs

@MrSimms MrSimms changed the title [lworld] CDS tests fail after the merge with master 8265719: [lworld] CDS tests fail after the merge with master May 4, 2021
@MrSimms
Copy link
Member Author

@MrSimms MrSimms commented May 4, 2021

/issue add JDK-8265719

@openjdk
Copy link

@openjdk openjdk bot commented May 4, 2021

@MrSimms This issue is referenced in the PR title - it will now be updated.

@MrSimms
Copy link
Member Author

@MrSimms MrSimms commented May 4, 2021

/integrate

@openjdk openjdk bot closed this May 4, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 4, 2021

@MrSimms Pushed as commit 74dbd64.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@MrSimms MrSimms deleted the 8265719 branch May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant