Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266582: [lworld] [lw3] C1 should have a flag to control use of delayed reads of flattened fields #403

Closed
wants to merge 3 commits into from

Conversation

@fparain
Copy link
Collaborator

@fparain fparain commented May 5, 2021

Trivial change to control the delayed read of nested flattened fields in C1.

Fred


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8266582: [lworld] [lw3] C1 should have a flag to control use of delayed reads of flattened fields

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/403/head:pull/403
$ git checkout pull/403

Update a local copy of the PR:
$ git checkout pull/403
$ git pull https://git.openjdk.java.net/valhalla pull/403/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 403

View PR using the GUI difftool:
$ git pr show -t 403

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/403.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 5, 2021

👋 Welcome back fparain! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented May 5, 2021

@fparain This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266582: [lworld] [lw3] C1 should have a flag to control use of delayed reads of flattened fields

Reviewed-by: dsimms, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the lworld branch:

  • f43fafc: 8265973: [lworld] C2 compilation fails due to infinite loop in PhaseIterGVN::optimize

Please see this link for an up-to-date comparison between the source branch of this pull request and the lworld branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented May 5, 2021

Webrevs

MrSimms
MrSimms approved these changes May 6, 2021
Copy link
Member

@MrSimms MrSimms left a comment

Looks fine to me

@fparain
Copy link
Collaborator Author

@fparain fparain commented May 6, 2021

Tobias, Mr Simms,

Thank you for the reviews.

Fred

@fparain
Copy link
Collaborator Author

@fparain fparain commented May 6, 2021

/integrate

@openjdk openjdk bot closed this May 6, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 6, 2021

@fparain Since your change was applied there has been 1 commit pushed to the lworld branch:

  • f43fafc: 8265973: [lworld] C2 compilation fails due to infinite loop in PhaseIterGVN::optimize

Your commit was automatically rebased without conflicts.

Pushed as commit b747817.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@fparain fparain deleted the c1_delayed_flag branch Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants