Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266582: [lworld] [lw3] C1 should have a flag to control use of delayed reads of flattened fields #403

Closed
wants to merge 3 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
@@ -1042,7 +1042,7 @@ void GraphBuilder::load_indexed(BasicType type) {
bool next_needs_patching = !next_field->holder()->is_loaded() ||
!next_field->will_link(method(), Bytecodes::_getfield) ||
PatchALot;
can_delay_access = !next_needs_patching;
can_delay_access = C1UseDelayedFlattenedFieldReads && !next_needs_patching;
}
if (can_delay_access) {
// potentially optimizable array access, storing information for delayed decision
@@ -1972,7 +1972,7 @@ void GraphBuilder::access_field(Bytecodes::Code code) {
bool next_needs_patching = !next_field->holder()->is_loaded() ||
!next_field->will_link(method(), Bytecodes::_getfield) ||
PatchALot;
can_delay_access = !next_needs_patching;
can_delay_access = C1UseDelayedFlattenedFieldReads && !next_needs_patching;
}
if (can_delay_access) {
if (has_pending_load_indexed()) {
@@ -332,7 +332,10 @@
"Update MethodData*s in Tier1-generated code") \
\
develop(bool, PrintCFGToFile, false, \
"print control flow graph to a separate file during compilation")
"print control flow graph to a separate file during compilation") \
\
develop(bool, C1UseDelayedFlattenedFieldReads, true, \
"Use delayed reads of flattened field to reduce buffering")

// end of C1_FLAGS