Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial runtime arrays support for L or Q type #411

Closed
wants to merge 1 commit into from

Conversation

@MrSimms
Copy link
Member

@MrSimms MrSimms commented May 11, 2021

Added InlineKlass::null_free_inline_array_klass() akin to Klass::array_klass()
but specifically for Q class descriptors, with a separate chain for array klass
for Q-type arrays.

TODO: metadata visitor and cleanup for the new chain of Q-type array classes


Progress

  • Change must not contain extraneous whitespace

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/411/head:pull/411
$ git checkout pull/411

Update a local copy of the PR:
$ git checkout pull/411
$ git pull https://git.openjdk.java.net/valhalla pull/411/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 411

View PR using the GUI difftool:
$ git pr show -t 411

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/411.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 11, 2021

👋 Welcome back dsimms! A progress list of the required criteria for merging this PR into lqagain will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented May 11, 2021

@MrSimms This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Initial runtime arrays support for L or Q type

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lqagain branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lqagain branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented May 11, 2021

Webrevs

@MrSimms
Copy link
Member Author

@MrSimms MrSimms commented May 12, 2021

/integrate

@openjdk openjdk bot closed this May 12, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 12, 2021

@MrSimms Pushed as commit a6f937b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@MrSimms MrSimms deleted the lqagain_arrays_1 branch May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant