Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266931: [lworld] [lw3] Test InlineTypeArrays.java fails because of incorrect instanceof behavior #413

Closed
wants to merge 1 commit into from

Conversation

fparain
Copy link
Collaborator

@fparain fparain commented May 17, 2021

Fix super types of null-free arrays of primitive classes ([LFoo; must be present in the list of super types of [QFoo;).

Fred


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8266931: [lworld] [lw3] Test InlineTypeArrays.java fails because of incorrect instanceof behavior

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/413/head:pull/413
$ git checkout pull/413

Update a local copy of the PR:
$ git checkout pull/413
$ git pull https://git.openjdk.java.net/valhalla pull/413/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 413

View PR using the GUI difftool:
$ git pr show -t 413

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/413.diff

@fparain fparain changed the base branch from lworld to lqagain May 17, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 17, 2021

👋 Welcome back fparain! A progress list of the required criteria for merging this PR into lqagain will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented May 17, 2021

@fparain This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266931: [lworld] [lw3] Test InlineTypeArrays.java fails because of incorrect instanceof behavior

Reviewed-by: dsimms

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lqagain branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lqagain branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented May 17, 2021

Webrevs

Copy link
Member

@MrSimms MrSimms left a comment

Looks good, nice catch

@fparain
Copy link
Collaborator Author

@fparain fparain commented May 17, 2021

Mr Simms,

Thank you for the review.

Fred

@fparain
Copy link
Collaborator Author

@fparain fparain commented May 17, 2021

/integrate

@openjdk openjdk bot closed this May 17, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 17, 2021

@fparain Pushed as commit ac1feac.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@fparain fparain deleted the array_super branch Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants