Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267428: Several features lack the EnableValhalla guard #417

Closed
wants to merge 1 commit into from

Conversation

@fparain
Copy link
Collaborator

@fparain fparain commented May 19, 2021

Add if(EnableValhalla) guards around:

  • injection of the IdentityObject interface
  • iteration over fields to pre-load primitive class fields
  • iteration of method arguments to eagerly load primitive class arguments
  • support for flattened and null-free fields in the interpreter

Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8267428: Several features lack the EnableValhalla guard

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/417/head:pull/417
$ git checkout pull/417

Update a local copy of the PR:
$ git checkout pull/417
$ git pull https://git.openjdk.java.net/valhalla pull/417/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 417

View PR using the GUI difftool:
$ git pr show -t 417

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/417.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 19, 2021

👋 Welcome back fparain! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented May 19, 2021

@fparain This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267428: Several features lack the EnableValhalla guard

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@fparain
Copy link
Collaborator Author

@fparain fparain commented May 19, 2021

/integrate

@openjdk openjdk bot closed this May 19, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 19, 2021

@fparain Pushed as commit 13e7d4a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

@mlbridge mlbridge bot commented May 19, 2021

Webrevs

@fparain fparain deleted the enable_valhalla_fix branch Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant