Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8244235: java.lang.NoSuchFieldError: this when initializing an inner class inside an inline type #42

Closed
wants to merge 1 commit into from

Conversation

@sadayapalam
Copy link
Collaborator

@sadayapalam sadayapalam commented May 12, 2020

Jim, Thanks for reviewing this small fix.

Basically, javac mistakenly treats references to 'this' as an instance field.
Fix is to handle this particular case specially and return the value factory
product which is the proxy for 'this' in the inline factory.

I renamed a method suitably for better clarity. Of the three call sites only
one needed change. It is implausible in the other two sites that the symbol
involved is 'this' (since 'this' cannot be assigned to and qualified this would
have been lowered already)


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8244235: java.lang.NoSuchFieldError: this when initializing an inner class inside an inline type

Reviewers

  • JimLaskey (no known github.com user name / role)

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/42/head:pull/42
$ git checkout pull/42

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 12, 2020

👋 Welcome back sadayapalam! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request.

@openjdk
Copy link

@openjdk openjdk bot commented May 12, 2020

@sadayapalam This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8244235: java.lang.NoSuchFieldError: this when initializing an inner class inside an inline type
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

There are currently no new commits on the lworld branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate ec1930c03b1f9e03c779e8475ef7b7ea7aa12013.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented May 12, 2020

Webrevs

@sadayapalam
Copy link
Collaborator Author

@sadayapalam sadayapalam commented May 12, 2020

/integrate

@openjdk openjdk bot closed this May 12, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels May 12, 2020
@openjdk
Copy link

@openjdk openjdk bot commented May 12, 2020

@sadayapalam
Pushed as commit 27858b0.

@sadayapalam sadayapalam deleted the JDK-8244235 branch May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants