Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267559: [lworld] [lw3] NPE thrown when attempting to write null to a null-free array has incorrect error message #422

Closed
wants to merge 1 commit into from

Conversation

@fparain
Copy link
Collaborator

@fparain fparain commented May 24, 2021

Please review this small fix in the error message of the NullPointerException thrown when trying to write null on a null-free array.

Thank you,

Fred


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8267559: [lworld] [lw3] NPE thrown when attempting to write null to a null-free array has incorrect error message

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/422/head:pull/422
$ git checkout pull/422

Update a local copy of the PR:
$ git checkout pull/422
$ git pull https://git.openjdk.java.net/valhalla pull/422/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 422

View PR using the GUI difftool:
$ git pr show -t 422

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/422.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 24, 2021

👋 Welcome back fparain! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented May 24, 2021

@fparain This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267559: [lworld] [lw3] NPE thrown when attempting to write null to a null-free array has incorrect error message

Reviewed-by: dsimms

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented May 24, 2021

Webrevs

Copy link
Member

@MrSimms MrSimms left a comment

Looks good

@fparain
Copy link
Collaborator Author

@fparain fparain commented May 25, 2021

Thank you for the review.

Fred

@fparain
Copy link
Collaborator Author

@fparain fparain commented May 25, 2021

/integrate

@openjdk openjdk bot closed this May 25, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 25, 2021

@fparain Since your change was applied there have been 2 commits pushed to the lworld branch:

  • 7e2f202: 8267672: [lworld] A couple of cleanups to Unified class file generation scheme
  • e150bd9: 8267542: [lworld] [lqagain] javac emits useless checkcast when accessing fields through the reference projection

Your commit was automatically rebased without conflicts.

Pushed as commit 340ecec.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@fparain fparain deleted the npe_message branch Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants