Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267710: [lworld][lw3] Hook AlwaysAtomicAccesses to primitive classes atomicity rules #427

Closed
wants to merge 2 commits into from

Conversation

@shipilev
Copy link
Contributor

@shipilev shipilev commented May 25, 2021

AlwaysAtomicAccesses was added in JDK 9 to aid the research in the costs of requiring the always-atomic accesses. It would be nice to hook it up to current Valhalla code that handles explicitly declared atomic primitive classes.

Testing:

  • ad-hoc jcstress tests with lworld and -XX:(-|+)AlwaysAtomicAccesses

Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8267710: [lworld][lw3] Hook AlwaysAtomicAccesses to primitive classes atomicity rules

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/427/head:pull/427
$ git checkout pull/427

Update a local copy of the PR:
$ git checkout pull/427
$ git pull https://git.openjdk.java.net/valhalla pull/427/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 427

View PR using the GUI difftool:
$ git pr show -t 427

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/427.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 25, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented May 25, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267710: [lworld][lw3] Hook AlwaysAtomicAccesses to primitive classes atomicity rules

Reviewed-by: fparain

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@fparain) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@mlbridge
Copy link

@mlbridge mlbridge bot commented May 25, 2021

Webrevs

Copy link
Collaborator

@fparain fparain left a comment

Looks good to me.

Fred

@shipilev
Copy link
Contributor Author

@shipilev shipilev commented May 25, 2021

Thanks! What are the rules here? Should I prefix the PR with "[lworld] [lw3]"? Should I just push after one approval?

@fparain
Copy link
Collaborator

@fparain fparain commented May 25, 2021

You can push now.
"[lworld] [lw3]" in the title of CR are more of a custom than a rule.
What is important is to have the labels (I've added them to the CR).

@fparain
Copy link
Collaborator

@fparain fparain commented May 25, 2021

Could you add the same fix to method FieldLayoutBuilder::inline_class_field_sorting()?
Thank you.

Fred

@shipilev shipilev changed the title 8267710: Hook AlwaysAtomicAccesses to primitive classes atomicity rules [lworld][lw3] 8267710: Hook AlwaysAtomicAccesses to primitive classes atomicity rules May 26, 2021
@shipilev
Copy link
Contributor Author

@shipilev shipilev commented May 26, 2021

OK, added, renamed, ran runtime/valhalla without problems.

@fparain
Copy link
Collaborator

@fparain fparain commented May 26, 2021

Thanks for the update.

Fred

@shipilev shipilev changed the title [lworld][lw3] 8267710: Hook AlwaysAtomicAccesses to primitive classes atomicity rules 8267710: [lworld][lw3] Hook AlwaysAtomicAccesses to primitive classes atomicity rules May 26, 2021
@shipilev
Copy link
Contributor Author

@shipilev shipilev commented May 26, 2021

/integrate

@openjdk openjdk bot added the sponsor label May 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 26, 2021

@shipilev
Your change (at version b16de71) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Contributor Author

@shipilev shipilev commented May 31, 2021

Any sponsors? :)

@TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented May 31, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented May 31, 2021

@TobiHartmann @shipilev Pushed as commit 0f1c33c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8267710-valhalla-aaa branch Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants