Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8230082: [lworld] Volatile field declaration in inline class fails with ClassFormatError #43

Closed
wants to merge 1 commit into from

Conversation

sadayapalam
Copy link
Collaborator

@sadayapalam sadayapalam commented May 12, 2020

Jim, could you please review this small fix ?

Basically while checking that both FINAL and VOLATILE are not simultaneously
on, we should also check implicitly computed flags.

(Perhaps all calls to disjoint should consider implicit flags - but after
spending some time, I couldn't construct other problematic scenarios, so
decided to mind my business and limit it to the case at hand)


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8230082: [lworld] Volatile field declaration in inline class fails with ClassFormatError

Reviewers

  • JimLaskey (no known github.com user name / role)

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/43/head:pull/43
$ git checkout pull/43

@bridgekeeper
Copy link

bridgekeeper bot commented May 12, 2020

👋 Welcome back sadayapalam! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request.

@openjdk
Copy link

openjdk bot commented May 12, 2020

@sadayapalam This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8230082: [lworld] Volatile field declaration in inline class fails with ClassFormatError
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the lworld branch:

  • 46a60ae: 8230082: [lworld] Volatile field declaration in inline class fails with ClassFormatError
  • 27858b0: 8244235: java.lang.NoSuchFieldError: this when initializing an inner class inside an inline type

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge lworld into your branch, and then specify the current head hash when integrating, like this: /integrate 46a60aeca16b3f91d5190793005891250c7e8bcb.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

mlbridge bot commented May 12, 2020

Webrevs

@sadayapalam
Copy link
Collaborator Author

sadayapalam commented May 12, 2020

/integrate

@openjdk openjdk bot closed this May 12, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels May 12, 2020
@openjdk
Copy link

openjdk bot commented May 12, 2020

@sadayapalam The following commits have been pushed to lworld since your change was applied:

  • 27858b0: 8244235: java.lang.NoSuchFieldError: this when initializing an inner class inside an inline type

Your commit was automatically rebased without conflicts.

Pushed as commit 46a60ae.

@sadayapalam sadayapalam deleted the JDK-8230082 branch May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants