Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8244810: [lworld] Decommission arrayStorageProperties from Klass:array_klass() et el #44

Closed
wants to merge 3 commits into from

Conversation

MrSimms
Copy link
Member

@MrSimms MrSimms commented May 13, 2020

First part of LW2 to LW3 arrays


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8244810: [lworld] Decommission arrayStorageProperties from Klass:array_klass() et el

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/44/head:pull/44
$ git checkout pull/44

@bridgekeeper
Copy link

bridgekeeper bot commented May 13, 2020

👋 Welcome back dsimms! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request.

@openjdk
Copy link

openjdk bot commented May 13, 2020

@MrSimms This change now passes all automated pre-integration checks, type /integrate in a new comment to proceed. After integration, the commit message will be:

8244810: [lworld] Decommission arrayStorageProperties from Klass:array_klass() et el
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 3 commits pushed to the lworld branch:

  • f87a1b4: 8243317: jdk/javadoc/doclet/testRecordTypes/TestRecordTypes.java fails multiple tests
  • 46a60ae: 8230082: [lworld] Volatile field declaration in inline class fails with ClassFormatError
  • 27858b0: 8244235: java.lang.NoSuchFieldError: this when initializing an inner class inside an inline type

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge lworld into your branch, and then specify the current head hash when integrating, like this: /integrate f87a1b4194376bc61518974c6015aa46477b2a9e.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@MrSimms
Copy link
Member Author

MrSimms commented May 13, 2020

Partially backing out of 8222525 (f497626)

@mlbridge
Copy link

mlbridge bot commented May 13, 2020

Webrevs

Copy link
Collaborator

@fparain fparain left a comment

Looks like a good start to remove ArrayStorageProperties.
My only strong concern is in oopFactory.cpp (see inline comment).

Fred

src/hotspot/share/memory/oopFactory.cpp Outdated Show resolved Hide resolved
@MrSimms
Copy link
Member Author

MrSimms commented May 14, 2020

/integrate

@openjdk openjdk bot closed this May 14, 2020
@openjdk openjdk bot added integrated and removed ready labels May 14, 2020
@openjdk
Copy link

openjdk bot commented May 14, 2020

@MrSimms The following commits have been pushed to lworld since your change was applied:

  • f87a1b4: 8243317: jdk/javadoc/doclet/testRecordTypes/TestRecordTypes.java fails multiple tests
  • 46a60ae: 8230082: [lworld] Volatile field declaration in inline class fails with ClassFormatError
  • 27858b0: 8244235: java.lang.NoSuchFieldError: this when initializing an inner class inside an inline type

Your commit was automatically rebased without conflicts.

Pushed as commit 2e5a958.

@openjdk openjdk bot removed the rfr label May 14, 2020
@MrSimms MrSimms deleted the 8244810 branch May 14, 2020
@mlbridge
Copy link

mlbridge bot commented May 14, 2020

Mailing list message from Frederic Parain on valhalla-dev:

On May 13, 2020, at 12:23, Frederic Parain <fparain at openjdk.java.net> wrote:

On Wed, 13 May 2020 09:54:31 GMT, David Simms <dsimms at openjdk.org> wrote:

First part of LW2 to LW3 arrays

David Simms has updated the pull request incrementally with one additional commit since the last revision:

Copyright syntax

Looks like a good start to remove `ArrayStorageProperties`.
My only strong concern is in `oopFactory.cpp` (see inline comment).

Fred

src/hotspot/share/memory/oopFactory.cpp line 155:

154: ValueArrayKlass* vak = ValueArrayKlass::cast(array->klass());
155: objArrayHandle oarray = new_objArray_handle(vak->element_klass()->super(),
156: array->length(), CHECK_(objArrayHandle()));

With the evolving model, it is not guaranteed that the direct super type will be an inline type, it might be safer to
create an `Object[]` instead.

Correction:
"With the evolving model, it is not guaranteed that the direct super type will *not* be an inline type, it might be safer
to create an `Object[]` instead.?

Fred

src/hotspot/share/oops/arrayStorageProperties.hpp line 2:

1: /*
2: * Copyright (c) 2019, 2020, Oracle and/or its affiliates. All rights reserved.
3: * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants