Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268418: [lworld] VM assert illegal mirror klass when calling Class::getInterfaces on a flat array #440

Closed
wants to merge 1 commit into from

Conversation

mlchung
Copy link
Member

@mlchung mlchung commented Jun 9, 2021

Fix the assert in JVM_GetClassInterfaces to check for flat array.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8268418: [lworld] VM assert illegal mirror klass when calling Class::getInterfaces on a flat array

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/440/head:pull/440
$ git checkout pull/440

Update a local copy of the PR:
$ git checkout pull/440
$ git pull https://git.openjdk.java.net/valhalla pull/440/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 440

View PR using the GUI difftool:
$ git pr show -t 440

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/440.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 9, 2021

👋 Welcome back mchung! A progress list of the required criteria for merging this PR into lqagain will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 9, 2021

@mlchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268418: [lworld] VM assert illegal mirror klass when calling Class::getInterfaces on a flat array

Reviewed-by: fparain

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the lqagain branch:

  • 3552074: 8268399: [BACKOUT] [lworld] Tests must be update after core reflection changes for the L/Q model
  • 8807adf: 8268389: [lworld] Tests must be update after core reflection changes for the L/Q model

Please see this link for an up-to-date comparison between the source branch of this pull request and the lqagain branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lqagain branch, type /integrate in a new comment.

@mlbridge
Copy link

mlbridge bot commented Jun 9, 2021

Webrevs

fparain
fparain approved these changes Jun 9, 2021
Copy link
Collaborator

@fparain fparain left a comment

Looks good to me.

Fred

@mlchung
Copy link
Member Author

mlchung commented Jun 9, 2021

/integrate

@openjdk openjdk bot closed this Jun 9, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 9, 2021
@openjdk
Copy link

openjdk bot commented Jun 9, 2021

@mlchung Since your change was applied there have been 2 commits pushed to the lqagain branch:

  • 3552074: 8268399: [BACKOUT] [lworld] Tests must be update after core reflection changes for the L/Q model
  • 8807adf: 8268389: [lworld] Tests must be update after core reflection changes for the L/Q model

Your commit was automatically rebased without conflicts.

Pushed as commit 31e9967.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlchung mlchung deleted the getInterfaces branch Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants