Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267597: [lworld] Withdraw all support for bifurcated class generation for primitive classes #441

Closed
wants to merge 1 commit into from

Conversation

@sadayapalam
Copy link
Collaborator

@sadayapalam sadayapalam commented Jun 10, 2021

Adjust code generation and tests to the new unified world view


Progress

  • Change must not contain extraneous whitespace

Issues

  • JDK-8267597: [lworld] Withdraw all support for bifurcated class generation for primitive classes
  • JDK-8268527: [lqagain] langtool tests need tweaks to run properly in an universe where -XDunifiedValRefClass is the default

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/441/head:pull/441
$ git checkout pull/441

Update a local copy of the PR:
$ git checkout pull/441
$ git pull https://git.openjdk.java.net/valhalla pull/441/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 441

View PR using the GUI difftool:
$ git pr show -t 441

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/441.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 10, 2021

👋 Welcome back sadayapalam! A progress list of the required criteria for merging this PR into lqagain will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@sadayapalam
Copy link
Collaborator Author

@sadayapalam sadayapalam commented Jun 10, 2021

/issue add JDK-8268527

@openjdk
Copy link

@openjdk openjdk bot commented Jun 10, 2021

@sadayapalam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267597: [lworld] Withdraw all support for bifurcated class generation for primitive classes
8268527: [lqagain] langtool tests need tweaks to run properly in an universe where -XDunifiedValRefClass is the default

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lqagain branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lqagain branch, type /integrate in a new comment.

@sadayapalam
Copy link
Collaborator Author

@sadayapalam sadayapalam commented Jun 10, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jun 10, 2021

@sadayapalam
Adding additional issue to issue list: 8268527: [lqagain] langtool tests need tweaks to run properly in an universe where -XDunifiedValRefClass is the default.

@openjdk openjdk bot closed this Jun 10, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 10, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 10, 2021

@sadayapalam Pushed as commit d23562e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 10, 2021

Webrevs

@sadayapalam sadayapalam deleted the JDK-8267597 branch Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant