Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268584: [lqagain] Javac tests should not needlessly hardcode toString() output #443

Closed
wants to merge 2 commits into from

Conversation

sadayapalam
Copy link
Collaborator

@sadayapalam sadayapalam commented Jun 11, 2021

Modify javac tests to not use textual comparisons of primitive object state as a means of verifying behavior


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8268584: [lqagain] Javac tests should not needlessly hardcode toString() output

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/443/head:pull/443
$ git checkout pull/443

Update a local copy of the PR:
$ git checkout pull/443
$ git pull https://git.openjdk.java.net/valhalla pull/443/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 443

View PR using the GUI difftool:
$ git pr show -t 443

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/443.diff

    Replace calls to toString() with alternate checks.
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 11, 2021

👋 Welcome back sadayapalam! A progress list of the required criteria for merging this PR into lqagain will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 11, 2021

@sadayapalam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268584: [lqagain] Javac tests should not needlessly hardcode toString() output

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lqagain branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lqagain branch, type /integrate in a new comment.

@sadayapalam
Copy link
Collaborator Author

sadayapalam commented Jun 11, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Jun 11, 2021

Going to push as commit 64ec4ec.

@openjdk openjdk bot closed this Jun 11, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 11, 2021
@openjdk
Copy link

openjdk bot commented Jun 11, 2021

@sadayapalam Pushed as commit 64ec4ec.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sadayapalam sadayapalam deleted the JDK-8268584 branch Jun 11, 2021
@mlbridge
Copy link

mlbridge bot commented Jun 11, 2021

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant