Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268671: [lworld] Wrong code generated for PrimitiveClass.ref.default #445

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
@@ -2404,7 +2404,7 @@ public void visitSelect(JCFieldAccess tree) {
}

public void visitDefaultValue(JCDefaultValue tree) {
if (tree.type.asElement().isPrimitiveClass()) {
if (tree.type.isPrimitiveClass()) {
code.emitop2(defaultvalue, checkDimension(tree.pos(), tree.type), PoolWriter::putClass);
} else if (tree.type.isReference()) {
code.emitop0(aconst_null);
@@ -0,0 +1,39 @@
/*
* Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation. Oracle designates this
* particular file as subject to the "Classpath" exception as provided
* by Oracle in the LICENSE file that accompanied this code.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/

/*
* @test
* @bug 8268671
* @summary Wrong code generated for PrimitiveClass.ref.default
* @run main DefaultOfPrimitiveReference
*/

public primitive class DefaultOfPrimitiveReference {
public static void main(String [] args) {
Object o = DefaultOfPrimitiveReference.ref.default;
if (o != null)
throw new AssertionError("Expected NPE is missing");
}
}