Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8268980: [lword] Fix Class::descriptorString to return L-descriptor for primitive ref type #451

Closed
wants to merge 5 commits into from

Conversation

@mlchung
Copy link
Member

@mlchung mlchung commented Jun 17, 2021


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8268980: [lword] Fix Class::descriptorString to return L-descriptor for primitive ref type

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/451/head:pull/451
$ git checkout pull/451

Update a local copy of the PR:
$ git checkout pull/451
$ git pull https://git.openjdk.java.net/valhalla pull/451/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 451

View PR using the GUI difftool:
$ git pr show -t 451

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/451.diff

@mlchung
Copy link
Member Author

@mlchung mlchung commented Jun 17, 2021

/integrate

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 17, 2021

👋 Welcome back mchung! A progress list of the required criteria for merging this PR into lqagain will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 17, 2021

@mlchung Your integration request cannot be fulfilled at this time, as the status check jcheck did not complete successfully

@openjdk
Copy link

@openjdk openjdk bot commented Jun 17, 2021

@mlchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268980: [lword] Fix Class::descriptorString to return L-descriptor for primitive ref type

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lqagain branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lqagain branch, type /integrate in a new comment.

@mlchung
Copy link
Member Author

@mlchung mlchung commented Jun 17, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jun 17, 2021

Going to push as commit 3b3e4d4.

@openjdk openjdk bot closed this Jun 17, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 17, 2021

@mlchung Pushed as commit 3b3e4d4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 17, 2021

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant