Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8268980: [lword] Fix Class::descriptorString to return L-descriptor for primitive ref type #451

Closed
wants to merge 5 commits into from
@@ -4518,7 +4518,7 @@ public String descriptorString() {
if (isArray()) {
return "[" + componentType.descriptorString();
}
char typeDesc = isPrimitiveClass() ? 'Q' : 'L';
char typeDesc = isValueType() ? 'Q' : 'L';
if (isHidden()) {
String name = getName();
int index = name.indexOf('/');
@@ -130,6 +130,9 @@ public void testMirrors() {

assertEquals(valType.getTypeName(), "BasicTest$Point");
assertEquals(refType.getTypeName(), "BasicTest$Point.ref");

assertEquals(valType.descriptorString(), "QBasicTest$Point;");
assertEquals(refType.descriptorString(), "LBasicTest$Point;");
}

/*
@@ -0,0 +1,46 @@
/*
* Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/

/*
* @test
* @run main MethodReference
* @summary test method reference and primitive reference type as the parameter type
*/

import java.util.function.Supplier;

public primitive class MethodReference {
final int x;
final int y;
MethodReference() {
this.x = 1234;
this.y = 5678;
}

public static void main(String... args) {
Supplier<MethodReference.ref> supplier = MethodReference::new;
MethodReference o = (MethodReference) supplier.get();
if (o.x != 1234 || o.y != 5678)
throw new AssertionError(o);
}
}