Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8268981: [lworld] UnifiedPrimitiveClassNestHostTest.java should test with the primary mirror #452

Closed
wants to merge 1 commit into from

Conversation

mlchung
Copy link
Member

@mlchung mlchung commented Jun 17, 2021

Fix the bug in test/langtools/tools/javac/valhalla/lworld-values/UnifiedPrimitiveClassNestHostTest.java test that verifies the nest host with a secondary mirror but the core reflection API returns the primary mirror.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8268981: [lworld] UnifiedPrimitiveClassNestHostTest.java should test with the primary mirror

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/452/head:pull/452
$ git checkout pull/452

Update a local copy of the PR:
$ git checkout pull/452
$ git pull https://git.openjdk.java.net/valhalla pull/452/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 452

View PR using the GUI difftool:
$ git pr show -t 452

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/452.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 17, 2021

👋 Welcome back mchung! A progress list of the required criteria for merging this PR into lqagain will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 17, 2021

@mlchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268981: [lworld] UnifiedPrimitiveClassNestHostTest.java should test with the primary mirror

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lqagain branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lqagain branch, type /integrate in a new comment.

@mlchung
Copy link
Member Author

mlchung commented Jun 17, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Jun 17, 2021

Going to push as commit 521bed2.

@openjdk openjdk bot closed this Jun 17, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 17, 2021
@openjdk
Copy link

openjdk bot commented Jun 17, 2021

@mlchung Pushed as commit 521bed2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Jun 17, 2021

Webrevs

@mlchung mlchung deleted the JDK-8268981 branch Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant