Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8269023 [lworld] L/Q<type> support #453

Closed
wants to merge 24 commits into from

Conversation

@MrSimms
Copy link
Member

@MrSimms MrSimms commented Jun 18, 2021

Merge work from lqagain branch


Progress

  • Change must not contain extraneous whitespace

Issue

Contributors

  • Frederic Parain <fparain@openjdk.org>
  • Tobias Hartmann <thartmann@openjdk.org>
  • Mandy Chung <mchung@openjdk.org>
  • Srikanth Adayapalam <sadayapalam@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/453/head:pull/453
$ git checkout pull/453

Update a local copy of the PR:
$ git checkout pull/453
$ git pull https://git.openjdk.java.net/valhalla pull/453/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 453

View PR using the GUI difftool:
$ git pr show -t 453

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/453.diff

David Simms and others added 22 commits May 10, 2021
…ncorrect instanceof behavior

Reviewed-by: dsimms
Reviewed-by: thartmann
…getInterfaces on a flat array

Reviewed-by: fparain
…n for primitive classes

8268527: [lqagain] langtool tests need tweaks to run properly in an universe where -XDunifiedValRefClass is the default
Merge lworld @jdk-18+2
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 18, 2021

👋 Welcome back dsimms! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 18, 2021

@MrSimms This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269023: [lworld] L/Q<type> support

Co-authored-by: Frederic Parain <fparain@openjdk.org>
Co-authored-by: Tobias Hartmann <thartmann@openjdk.org>
Co-authored-by: Mandy Chung <mchung@openjdk.org>
Co-authored-by: Srikanth Adayapalam <sadayapalam@openjdk.org>

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@MrSimms
Copy link
Member Author

@MrSimms MrSimms commented Jun 18, 2021

/contributor add fparain

@openjdk
Copy link

@openjdk openjdk bot commented Jun 18, 2021

@MrSimms
Contributor Frederic Parain <fparain@openjdk.org> successfully added.

@MrSimms
Copy link
Member Author

@MrSimms MrSimms commented Jun 18, 2021

/contributor add TobiHartmann

@openjdk
Copy link

@openjdk openjdk bot commented Jun 18, 2021

@MrSimms Could not parse TobiHartmann as a valid contributor.
Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

  • /contributor add @openjdk-bot
  • /contributor add duke
  • /contributor add J. Duke <duke@openjdk.org>

@MrSimms
Copy link
Member Author

@MrSimms MrSimms commented Jun 18, 2021

/contributor add thartmann

@openjdk
Copy link

@openjdk openjdk bot commented Jun 18, 2021

@MrSimms
Contributor Tobias Hartmann <thartmann@openjdk.org> successfully added.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 18, 2021

Webrevs

@MrSimms
Copy link
Member Author

@MrSimms MrSimms commented Jun 18, 2021

/contributor add mchung

@openjdk
Copy link

@openjdk openjdk bot commented Jun 18, 2021

@MrSimms
Contributor Mandy Chung <mchung@openjdk.org> successfully added.

@MrSimms
Copy link
Member Author

@MrSimms MrSimms commented Jun 18, 2021

/contributor add sadayapalam

@openjdk
Copy link

@openjdk openjdk bot commented Jun 18, 2021

@MrSimms
Contributor Srikanth Adayapalam <sadayapalam@openjdk.org> successfully added.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 21, 2021

@MrSimms this pull request can not be integrated into lworld due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout close_lqagain
git fetch https://git.openjdk.java.net/valhalla lworld
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge lworld"
git push

@openjdk openjdk bot added merge-conflict and removed ready labels Jun 21, 2021
@openjdk openjdk bot added ready and removed merge-conflict labels Jun 21, 2021
@MrSimms
Copy link
Member Author

@MrSimms MrSimms commented Jun 21, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jun 21, 2021

Going to push as commit 3c399d9.

@openjdk openjdk bot closed this Jun 21, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 21, 2021

@MrSimms Pushed as commit 3c399d9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@MrSimms MrSimms deleted the close_lqagain branch Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants