Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8218159: ValueBootstrapMethods.isSubstitutable should not filter synthetic fields #454

Closed
wants to merge 1 commit into from

Conversation

@mlchung
Copy link
Member

@mlchung mlchung commented Jun 18, 2021

acmp on two primitive objects of the same type are considered equals if all of their fields are "equivalent" including synthetic fields, for example, which can be an enclosing instance and captured outer locals.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8218159: ValueBootstrapMethods.isSubstitutable should not filter synthetic fields

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/454/head:pull/454
$ git checkout pull/454

Update a local copy of the PR:
$ git checkout pull/454
$ git pull https://git.openjdk.java.net/valhalla pull/454/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 454

View PR using the GUI difftool:
$ git pr show -t 454

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/454.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 18, 2021

👋 Welcome back mchung! A progress list of the required criteria for merging this PR into lqagain will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 18, 2021

@mlchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8218159: ValueBootstrapMethods.isSubstitutable should not filter synthetic fields

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lqagain branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lqagain branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 18, 2021

Webrevs

@mlchung
Copy link
Member Author

@mlchung mlchung commented Jun 18, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jun 18, 2021

Going to push as commit 2a7e977.

@openjdk openjdk bot closed this Jun 18, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 18, 2021

@mlchung Pushed as commit 2a7e977.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlchung mlchung deleted the inner-class branch Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant