Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8269095: Fix Valhalla Zero build failures #458

Closed
wants to merge 1 commit into from

Conversation

@shipilev
Copy link
Contributor

@shipilev shipilev commented Jun 22, 2021

This should make Zero buildable again in Valhalla workspace. Zero would not work with primitive classes just yet, failing with "unimplemented bytecode" when reaching the Valhalla code, but at least it would not fail the builds.


Progress

  • Change must not contain extraneous whitespace

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/458/head:pull/458
$ git checkout pull/458

Update a local copy of the PR:
$ git checkout pull/458
$ git pull https://git.openjdk.java.net/valhalla pull/458/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 458

View PR using the GUI difftool:
$ git pr show -t 458

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/458.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 22, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 22, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269095: Fix Valhalla Zero build failures

Reviewed-by: dsimms

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@MrSimms) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 22, 2021

Webrevs

Copy link
Member

@MrSimms MrSimms left a comment

This looks fine

@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Jun 23, 2021

Thanks!

/integrate

@openjdk openjdk bot added the sponsor label Jun 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 23, 2021

@shipilev
Your change (at version 20c52cc) is now ready to be sponsored by a Committer.

@MrSimms
Copy link
Member

@MrSimms MrSimms commented Jun 23, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Jun 23, 2021

Going to push as commit 936d430.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 23, 2021

@MrSimms @shipilev Pushed as commit 936d430.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8269095-valhalla-zero branch Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants