Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8269172: Add java.util.Objects.newIdentity method #459

Closed
wants to merge 1 commit into from

Conversation

@RogerRiggs
Copy link
Collaborator

@RogerRiggs RogerRiggs commented Jun 22, 2021

Replaces the existing Objects.newIdentity() method with the matching method in JDK17.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8269172: Add java.util.Objects.newIdentity method

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/459/head:pull/459
$ git checkout pull/459

Update a local copy of the PR:
$ git checkout pull/459
$ git pull https://git.openjdk.java.net/valhalla pull/459/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 459

View PR using the GUI difftool:
$ git pr show -t 459

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/459.diff

Replaces the existing Objects.newIdentity() method with the matching method in JDK17.
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 22, 2021

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 22, 2021

@RogerRiggs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269172: Add java.util.Objects.newIdentity method

Reviewed-by: mchung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 22, 2021

Webrevs

Copy link
Member

@mlchung mlchung left a comment

It's fine to bring this in early. Or it could simply wait until lworld is sync'ed with jdk after JDK-8269096 is integrated and pulled down to the master.

@RogerRiggs
Copy link
Collaborator Author

@RogerRiggs RogerRiggs commented Jun 22, 2021

Yep, I figured to preempt a question about how to resolve the conflict between the old impl and new one and save some head-scratching.

@RogerRiggs
Copy link
Collaborator Author

@RogerRiggs RogerRiggs commented Jun 23, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jun 23, 2021

Going to push as commit bb10711.
Since your change was applied there has been 1 commit pushed to the lworld branch:

  • 936d430: 8269095: Fix Valhalla Zero build failures

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jun 23, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 23, 2021

@RogerRiggs Pushed as commit bb10711.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants