Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8269231: Fix 32-bit Valhalla (Zero) builds #460

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Contributor

@shipilev shipilev commented Jun 23, 2021

Building linux-x86-zero-fastdebug builds shows a few 32-bit cleanliness problems.

The first failure is:

/home/buildbot/worker/build-jdkX-valhalla-linux/build/src/hotspot/share/oops/oop.inline.hpp:210:5: error: "_LP64" is not defined [-Werror=undef]
 #if _LP64
     ^~~~~

Additional testing:

  • Linux x86 Zero fastdebug completes
  • Linux x86_64 Server fastdebug runs runtime/valhalla (no new regressions, some failures with clean lworld)
  • Linux x86_64 Server fastdebug runs compiler/valhalla (no new regressions, some failures with clean lworld)

Progress

  • Change must not contain extraneous whitespace

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/460/head:pull/460
$ git checkout pull/460

Update a local copy of the PR:
$ git checkout pull/460
$ git pull https://git.openjdk.java.net/valhalla pull/460/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 460

View PR using the GUI difftool:
$ git pr show -t 460

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/460.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 23, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 23, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269231: Fix 32-bit Valhalla (Zero) builds

Reviewed-by: dsimms

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the lworld branch:

  • bb10711: 8269172: Add java.util.Objects.newIdentity method

Please see this link for an up-to-date comparison between the source branch of this pull request and the lworld branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@MrSimms) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 23, 2021

Webrevs

Copy link
Member

@MrSimms MrSimms left a comment

Thanks for cleaning the 32-bit zero builds too

@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Jun 23, 2021

Yup. I think the vast majority of these issues would break x86_32-server too, but that would also need some macroAssembler fixes to work. I have a few prototype fixes there. Meanwhile, it would be nice to unbreak 32-bit Zero builds.

/integrate

@openjdk openjdk bot added the sponsor label Jun 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 23, 2021

@shipilev
Your change (at version 8fed9db) is now ready to be sponsored by a Committer.

@MrSimms
Copy link
Member

@MrSimms MrSimms commented Jun 23, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Jun 23, 2021

Going to push as commit f2538f4.
Since your change was applied there has been 1 commit pushed to the lworld branch:

  • bb10711: 8269172: Add java.util.Objects.newIdentity method

Your commit was automatically rebased without conflicts.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 23, 2021

@MrSimms @shipilev Pushed as commit f2538f4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8269231-zero-32bit branch Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants