Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268021: [lworld] [AArch64] fix support for InlineTypeReturnedAsFields #461

Closed
wants to merge 1 commit into from

Conversation

nick-arm
Copy link
Member

@nick-arm nick-arm commented Jun 24, 2021

The code to support this on AArch64 was already mostly written but
untested or bit-rotted. This patch also contains the allocation
optimisation to MacroAssembler::store_inline_type_fields_to_buf() from
JDK-8263067.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8268021: [lworld] [AArch64] fix support for InlineTypeReturnedAsFields

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/461/head:pull/461
$ git checkout pull/461

Update a local copy of the PR:
$ git checkout pull/461
$ git pull https://git.openjdk.java.net/valhalla pull/461/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 461

View PR using the GUI difftool:
$ git pr show -t 461

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/461.diff

The code to support this on AArch64 was already mostly written but
untested or bit-rotted. This patch also contains the allocation
optimisation to MacroAssembler::store_inline_type_fields_to_buf() from
JDK-8263067.
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 24, 2021

👋 Welcome back ngasson! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 24, 2021

@nick-arm This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268021: [lworld] [AArch64] fix support for InlineTypeReturnedAsFields

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the lworld branch:

  • bfd6f2c: Adjust testing
  • 2b8e967: 8269279: [lworld] 8269231 causes build failures

Please see this link for an up-to-date comparison between the source branch of this pull request and the lworld branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 24, 2021

Webrevs

@rwestrel
Copy link
Collaborator

@rwestrel rwestrel commented Jun 24, 2021

I didn't review this in details but given this is all aarch64 specific (except for one minor change), this is good to integrate. Do you want me to sponsor it?

@nick-arm
Copy link
Member Author

@nick-arm nick-arm commented Jun 25, 2021

I didn't review this in details but given this is all aarch64 specific (except for one minor change), this is good to integrate. Do you want me to sponsor it?

Yes that would be great, thanks.

@rwestrel
Copy link
Collaborator

@rwestrel rwestrel commented Jun 25, 2021

First time I sponsor a change. It seems you have to do /integrate first.

@nick-arm
Copy link
Member Author

@nick-arm nick-arm commented Jun 25, 2021

/integrate

@openjdk openjdk bot added the sponsor label Jun 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 25, 2021

@nick-arm
Your change (at version 4fe181a) is now ready to be sponsored by a Committer.

@rwestrel
Copy link
Collaborator

@rwestrel rwestrel commented Jun 25, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Jun 25, 2021

Going to push as commit 21090e0.
Since your change was applied there have been 2 commits pushed to the lworld branch:

  • bfd6f2c: Adjust testing
  • 2b8e967: 8269279: [lworld] 8269231 causes build failures

Your commit was automatically rebased without conflicts.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 25, 2021

@rwestrel @nick-arm Pushed as commit 21090e0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants