Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8269279: [lworld] 8269231 causes build failures #463

Closed
wants to merge 2 commits into from

Conversation

@MrSimms
Copy link
Member

@MrSimms MrSimms commented Jun 24, 2021

Removed signed hex formats since "x" is unsigned by definition


Progress

  • Change must not contain extraneous whitespace

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/463/head:pull/463
$ git checkout pull/463

Update a local copy of the PR:
$ git checkout pull/463
$ git pull https://git.openjdk.java.net/valhalla pull/463/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 463

View PR using the GUI difftool:
$ git pr show -t 463

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/463.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 24, 2021

👋 Welcome back dsimms! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 24, 2021

@MrSimms This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269279: [lworld] 8269231 causes build failures

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 24, 2021

Webrevs

Copy link
Contributor

@shipilev shipilev left a comment

Oh! Right. Since we are casting to uint64_t, probably better use UINT64_FORMAT_X directly?

@MrSimms
Copy link
Member Author

@MrSimms MrSimms commented Jun 24, 2021

Oh! Right. Since we are casting to uint64_t, probably better use UINT64_FORMAT_X directly?

Six of one, half a dozen of the other, the argument is a jlong and JULONG_FORMAT_X exists which required less typing. JULONG_FORMAT_X existence should probably invoke questions with the reader "an unsigned format for a clearly signed type ?".

@shipilev
Copy link
Contributor

@shipilev shipilev commented Jun 24, 2021

Oh! Right. Since we are casting to uint64_t, probably better use UINT64_FORMAT_X directly?

Six of one, half a dozen of the other, the argument is a jlong and JULONG_FORMAT_X exists which required less typing. JULONG_FORMAT_X existence should probably invoke questions with the reader "an unsigned format for a clearly signed type ?".

Well, it confuses me a bit that we cast jlong to uint64_t and then format it as JULONG_FORMAT_X. Yes, it works right now because JULONG_FORMAT_X is defined as UINT64_FORMAT_X. I just thought it would be cleaner to say jlong -> uint64_t -> UINT64_FORMAT_X.

Copy link
Contributor

@shipilev shipilev left a comment

Cool, thanks.

@MrSimms
Copy link
Member Author

@MrSimms MrSimms commented Jun 24, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jun 24, 2021

Going to push as commit 2b8e967.

@openjdk openjdk bot closed this Jun 24, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 24, 2021

@MrSimms Pushed as commit 2b8e967.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants