New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8269279: [lworld] 8269231 causes build failures #463
Conversation
|
@MrSimms This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the
|
Webrevs
|
Oh! Right. Since we are casting to uint64_t
, probably better use UINT64_FORMAT_X
directly?
Six of one, half a dozen of the other, the argument is a |
Well, it confuses me a bit that we cast |
/integrate |
Going to push as commit 2b8e967. |
Removed signed hex formats since "x" is unsigned by definition
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/463/head:pull/463
$ git checkout pull/463
Update a local copy of the PR:
$ git checkout pull/463
$ git pull https://git.openjdk.java.net/valhalla pull/463/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 463
View PR using the GUI difftool:
$ git pr show -t 463
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/463.diff