Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8269792: [lworld] Duplicate/redundant CONSTANT_Class_info entry in constant pool #471

Closed
wants to merge 1 commit into from

Conversation

@sadayapalam
Copy link
Collaborator

@sadayapalam sadayapalam commented Jul 2, 2021

Do not emit distinct Constant_class_info entries for Foo.ref and Foo.val


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8269792: [lworld] Duplicate/redundant CONSTANT_Class_info entry in constant pool

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/471/head:pull/471
$ git checkout pull/471

Update a local copy of the PR:
$ git checkout pull/471
$ git pull https://git.openjdk.java.net/valhalla pull/471/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 471

View PR using the GUI difftool:
$ git pr show -t 471

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/471.diff

    Coalesce the Constant_class_info structures for Foo.ref and Foo.val into one.
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 2, 2021

👋 Welcome back sadayapalam! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 2, 2021

@sadayapalam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269792: [lworld] Duplicate/redundant CONSTANT_Class_info entry in constant pool

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@sadayapalam
Copy link
Collaborator Author

@sadayapalam sadayapalam commented Jul 2, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 2, 2021

Going to push as commit b3b7fb2.

@openjdk openjdk bot closed this Jul 2, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 2, 2021

@sadayapalam Pushed as commit b3b7fb2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sadayapalam sadayapalam deleted the JDK-8269792 branch Jul 2, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 2, 2021

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant