Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8269536: Fix verifier withfield test #477

Closed
wants to merge 1 commit into from

Conversation

hseigel
Copy link
Member

@hseigel hseigel commented Jul 12, 2021

Please review this small change to push a test fix for VerifierInlineTypes.java that was in branch lqagain to branch lworld. The fix removes, from the jcod classes, improper and unneeded methods that were causing unwanted ClassFormatError exceptions. The change also removes tests that are no longer applicable.

The changes were tested by running Mach5 tiers 1 and 2 on Linux, Mac OS, and Windows.

Thanks, Harold


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8269536: Fix verifier withfield test ⚠️ Issue is not open.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/477/head:pull/477
$ git checkout pull/477

Update a local copy of the PR:
$ git checkout pull/477
$ git pull https://git.openjdk.java.net/valhalla pull/477/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 477

View PR using the GUI difftool:
$ git pr show -t 477

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/477.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 12, 2021

👋 Welcome back hseigel! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 12, 2021

@hseigel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269536: Fix verifier withfield test

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

mlbridge bot commented Jul 12, 2021

Webrevs

@hseigel
Copy link
Member Author

hseigel commented Jul 12, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Jul 12, 2021

Going to push as commit 7f972be.

@openjdk openjdk bot closed this Jul 12, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 12, 2021
@openjdk
Copy link

openjdk bot commented Jul 12, 2021

@hseigel Pushed as commit 7f972be.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant